After removing db.close() calls, 22 finally: blocks were left empty
(12 in custom_commands.py, 10 in help_commands.py), causing
IndentationError at import time. Removed the finally: clause entirely
since connection lifecycle is now handled by the middleware.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sp.on_first/on_second/on_third don't exist — the actual columns are
on_first_id/on_second_id/on_third_id. This caused failures when
updating season pitching stats after games.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The decorator was catching all exceptions including intentional
HTTPException (401, 404, etc.) and re-wrapping them as 500 "Database
error". This masked auth failures and other deliberate HTTP errors.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The MAX_LIMIT/DEFAULT_LIMIT caps added in 16f3f8d are too restrictive
for the /players endpoint — bot and website consumers need full player
lists without pagination. Reverts limit param to Optional[int] with no
ceiling while keeping caps on all other endpoints.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Capture total_count before .limit() so the response count reflects
all matching rows, not just the capped page size. Resolves#100.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add MAX_LIMIT=500 cap across all list endpoints, empty string
stripping middleware, and limit/offset to /transactions. Resolves#98.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add DISCORD_WEBHOOK_URL to docker-compose.yml api service environment block
- Add empty placeholder entry in .env for discoverability
- Move DISCORD_WEBHOOK_URL constant to the env-var constants section at top of dependencies.py
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace inline webhook URL+token with DISCORD_WEBHOOK_URL env var.
Logs a warning and returns False gracefully if the var is unset.
The exposed webhook token should be rotated in Discord.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Raise RuntimeError on startup if POSTGRES_PASSWORD env var is not set,
instead of silently falling back to a known password in source code.
Closes #C2 from postgres migration review.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Closes#65
`PitchingStat.combined_season()` was referenced in the `get_pitstats`
handler but never defined, causing a 500 on `s_type=combined/total/all`.
Added `combined_season` as a `@staticmethod` matching the pattern of
`BattingStat.combined_season` — returns all rows for the given season
with no week filter (both regular and postseason).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Guard bulk ID queries against empty lists to prevent PostgreSQL
syntax error (WHERE id IN ()) when batch POST endpoints receive
empty request bodies.
Affected endpoints:
- POST /api/v3/transactions
- POST /api/v3/results
- POST /api/v3/schedules
- POST /api/v3/battingstats
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace per-row Team/Player lookups with bulk IN-list queries before
the validation loop in post_transactions, post_results, post_schedules,
and post_batstats. A 50-move batch now uses 2 queries instead of 150.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add finally blocks to update_player, patch_player, create_players, and
delete_player in PlayerService to call invalidate_related_cache() using
the existing cache_patterns. Matches the pattern already used in
TeamService.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Apply .offset() and .limit() on the Peewee query before materializing
results, instead of fetching all rows into memory and slicing in Python.
Total count is obtained via query.count() before pagination is applied.
In-memory (mock) queries continue to use Python-level slicing.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Both fields were hardcoded to 0.0 in the INSERT. Added SQL expressions
to the pitching_stats CTE to calculate them from stratplay data, using
the same logic as the batting stats endpoint.
- lob_2outs: count of runners stranded when pitcher recorded the 3rd out
- rbipercent: RBI allowed (excluding HR) per runner opportunity
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
aiohttp follows 307 redirects but converts POST to GET, silently
dropping the request body. Standardize all @router.post('') to
@router.post('/') so the canonical URL always has a trailing slash,
preventing 307 redirects when clients POST with trailing slashes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The team_abbrev filter uppercased input but compared against mixed-case
DB values (e.g. "MKEMiL"), causing affiliate roster transactions to be
silently dropped from results. Use fn.UPPER() on the DB column to match.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Peewee's order_by() returns a new queryset and does not sort in place.
Both branches were discarding the result, so the sort parameter had no
effect. Assign back to all_games so the query is actually ordered.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Enables career-total aggregation by real-world player identity (SbaPlayer)
across all seasons. JOINs StratPlay → Player to access Player.sbaplayer FK,
groups by that FK, and excludes players with null sbaplayer. Also refactors
stratplay router from single file into package and adds integration tests.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Enables cross-season stat queries by MLB player identity (SbaPlayer) without
requiring callers to look up every season-specific Player ID first. Filters
via Player subquery since StratPlay has no direct FK to SbaPlayer.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Provide targeted context for each app subdirectory so Claude Code
understands local patterns without relying on the root CLAUDE.md.
Also simplifies root CLAUDE.md dev/prod environment sections.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The teams PATCH endpoint included the `data` variable itself when
building the update dict via locals(), causing Peewee to fail with
"type object 'Team' has no attribute 'data'". The players endpoint
had the same pattern with a workaround that was order-dependent.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The standings recalculate function was processing games in arbitrary database
order, causing win/loss streaks to be calculated incorrectly. Added explicit
ordering by week and game_num (ascending) to ensure games are processed
chronologically.
This fixes inconsistent streak values that were reported due to the streak
logic depending on processing games in the correct temporal sequence.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
**Problem:**
The /players/search endpoint with all_seasons=True was taking 15+ seconds,
causing Discord autocomplete timeouts (3-second limit). The endpoint was
loading ALL players from ALL seasons into memory, then doing Python string
matching - extremely inefficient.
**Solution:**
1. Use SQL LIKE filtering at database level instead of Python iteration
2. Limit query results at database level (not after fetching all records)
3. Add functional index on LOWER(name) for faster case-insensitive search
**Performance Impact:**
- Before: 15+ seconds (loads 10,000+ player records)
- After: <500ms (database-level filtering with index)
- 30x faster response time
**Changes:**
- app/services/player_service.py: Use Peewee fn.Lower().contains() for SQL filtering
- migrations/2026-02-06_add_player_name_index.sql: Add index on LOWER(name)
- VERSION: Bump to 2.6.0 (minor version for performance improvement)
**Testing:**
Test with: https://sba.manticorum.com/api/v3/players/search?q=trea%20t&season=0&limit=30
Fixes Discord bot /player autocomplete timeout errors (error code 10062)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The search_players() method was hardcoding short_output=True when
converting query results to dicts, ignoring the function parameter.
This caused the /api/v3/players/search endpoint to always return
team_id as an integer instead of nested team objects, even when
short_output=False was specified.
Impact:
- Discord bot's /injury clear command was crashing because
player.team was None (only team_id was populated)
- Any code using search endpoint couldn't get full team data
Fix:
- Changed line 386 to use the short_output parameter value
- Now respects short_output parameter: False returns full team
objects, True returns just team IDs
Root cause analysis from production logs:
- Error: AttributeError: 'NoneType' object has no attribute 'roster_type'
- Location: commands/injuries/management.py:647
- Cause: player.team was None after search_players() call
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
CRITICAL BUG FIX - Root cause of Player.data AttributeError
Problem:
The PATCH endpoint was calling locals() AFTER creating data = {}, causing
locals_dict to capture 'data' and 'locals_dict' as variables. The loop then
added these to the data dict itself, resulting in:
data = {'team_id': 549, 'demotion_week': 7, 'data': {}, 'locals_dict': {...}}
When Peewee executed Player.update(**data), it tried to set Player.data = {},
but Player model has no 'data' field, causing AttributeError.
Solution:
1. Call locals() BEFORE creating data dict
2. Exclude 'locals_dict' from the filter (along with 'player_id', 'token')
This ensures only actual player field parameters are included in the update.
Version: 2.5.2 → 2.5.3
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add limit and offset parameters for paginated player queries.
Changes:
- Add limit parameter (minimum 1) to control page size
- Add offset parameter (minimum 0) to skip results
- Response now includes both 'count' (current page) and 'total' (all matches)
- Pagination applied after filtering and sorting
Example usage:
/api/v3/players?season=12&limit=50&offset=0 (page 1)
/api/v3/players?season=12&limit=50&offset=50 (page 2)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The pitcher_injury column is no longer used but was being included in all
player responses after the service layer refactor. This change restores the
previous behavior of filtering it out.
Changes:
- Add EXCLUDED_FIELDS class constant to PlayerService
- Filter excluded fields in _player_to_dict() method
- Update _query_to_player_dicts() to use _player_to_dict() for all conversions
- Applies to both JSON and CSV responses
Version bump: 2.4.1 -> 2.4.2
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Integration testing revealed three issues with the refactored service layer:
1. CSV Export Format
- Nested team/sbaplayer dicts were being dumped as strings
- Now flattens team to abbreviation, sbaplayer to ID
- Matches original CSV format from pre-refactor code
2. Season=0 Filter
- season=0 was filtering for WHERE season=0 (returns nothing)
- Now correctly returns all seasons when season=0 or None
- Affects 13,266 total players across all seasons
3. Generic Position "P"
- pos=P returned no results (players have SP/RP/CP, not P)
- Now expands P to match SP, RP, CP pitcher positions
- Applied to both DB filtering and Python mock filtering
4. Roster Endpoint Enhancement
- Added default /teams/{id}/roster endpoint (assumes 'current')
- Existing /teams/{id}/roster/{which} endpoint unchanged
All changes maintain backward compatibility and pass integration tests.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
