fieldingstats.get_fieldingstats: count computed after limit applied #100

New Issue

cal · 2026-04-01T22:39:38Z

cal commented

2026-04-01 22:39:38 +00:00

Problem

In app/routers_v3/fieldingstats.py, the get_fieldingstats endpoint calls .count() after .limit() is applied to the queryset. This means the count field in the response is capped at the limit value (200 by default) rather than reflecting the total number of matching records.

Expected Behavior

count should reflect the total matching rows before pagination, consistent with every other paginated endpoint.

Fix

Capture total_count = all_stats.count() before the .limit() call, then use total_count in the response dict.

Found during review of PR #99 (limit caps). Will be fixed in that PR.

## Problem In `app/routers_v3/fieldingstats.py`, the `get_fieldingstats` endpoint calls `.count()` after `.limit()` is applied to the queryset. This means the `count` field in the response is capped at the limit value (200 by default) rather than reflecting the total number of matching records. ## Expected Behavior `count` should reflect the total matching rows before pagination, consistent with every other paginated endpoint. ## Fix Capture `total_count = all_stats.count()` before the `.limit()` call, then use `total_count` in the response dict. Found during review of PR #99 (limit caps). Will be fixed in that PR.

cal referenced this issue from a commit

2026-04-01 22:40:09 +00:00

Fix fieldingstats count computed after limit applied

cal closed this issue

2026-04-01 22:44:43 +00:00

Sign in to join this conversation.