cal/major-domo-database
1
0
Fork 0
Code Issues 25 Pull Requests 25 Actions Packages Projects Releases Wiki Activity

fix: Sort games chronologically in standings recalculation for accurate streaks
Some checks failed
Build Docker Image / build (pull_request) Failing after 20s
Details

Browse Source 
The standings recalculate function was processing games in arbitrary database
order, causing win/loss streaks to be calculated incorrectly. Added explicit
ordering by week and game_num (ascending) to ensure games are processed
chronologically.

This fixes inconsistent streak values that were reported due to the streak
logic depending on processing games in the correct temporal sequence.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Cal Corum 2026-02-10 14:38:18 -06:00
parent 8fb8f82433
commit 126ce53951
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/db_engine.py
View File

@ -1326,7 +1326,8 @@ class Standings(BaseModel):
# Iterate through each individual result
# for game in Result.select_season(season).where(Result.week <= 22):
for game in StratGame.select().where(
(StratGame.season == season) & (StratGame.week <= 18) & (StratGame.game_num.is_null(False))):
(StratGame.season == season) & (StratGame.week <= 18) & (StratGame.game_num.is_null(False))
).order_by(StratGame.week, StratGame.game_num):
# tally win and loss for each standings object
game.update_standings()