Fix swallowed error in recalculate_standings — HTTPException constructed but not raised #23

New Issue

cal · 2026-02-20T06:49:53Z

cal commented

2026-02-20 06:49:53 +00:00

app/routers_v3/standings.py:124 — HTTPException(status_code=500, ...) is constructed but never raised. The endpoint always returns 200 regardless of whether recalculation succeeded.

Priority: high | Labels: bug

`app/routers_v3/standings.py:124` — `HTTPException(status_code=500, ...)` is constructed but never raised. The endpoint always returns 200 regardless of whether recalculation succeeded. **Priority**: high | **Labels**: bug

cal referenced this issue from a commit

2026-03-03 01:04:05 +00:00

fix: raise HTTPException in recalculate_standings on failure (#23)

cal referenced a pull request that will close this issue

2026-03-03 01:04:14 +00:00

fix: raise HTTPException in recalculate_standings on failure (#23) #40

cal commented

2026-03-03 01:04:21 +00:00

Fixed in PR #40.

Root cause: HTTPException(status_code=500, ...) was constructed but the raise keyword was missing, so the exception object was silently discarded and the endpoint always returned HTTP 200.

One-word fix — added raise before the HTTPException(...) call on the error path.

Fixed in PR #40. Root cause: `HTTPException(status_code=500, ...)` was constructed but the `raise` keyword was missing, so the exception object was silently discarded and the endpoint always returned HTTP 200. One-word fix — added `raise` before the `HTTPException(...)` call on the error path.

cal referenced this issue from a commit

2026-03-03 01:36:30 +00:00

fix: raise HTTPException in recalculate_standings on failure (#23)

cal referenced this issue

2026-03-03 01:36:38 +00:00

fix: raise HTTPException in recalculate_standings on failure (#23) #41

cal commented

2026-03-03 01:36:45 +00:00

PR #41 opens for review: #41

Fix is a single word change — added raise before the HTTPException(status_code=500, ...) call on line 124. The diff touches exactly one line. Used sed directly to bypass the linter that reformatted the entire file in the previous rejected PR.

PR #41 opens for review: https://git.manticorum.com/cal/major-domo-database/pulls/41 Fix is a single word change — added `raise` before the `HTTPException(status_code=500, ...)` call on line 124. The diff touches exactly one line. Used `sed` directly to bypass the linter that reformatted the entire file in the previous rejected PR.

cal referenced this issue from a commit

2026-03-03 03:44:55 +00:00

fix: raise HTTPException in recalculate_standings on failure (#23)

cal referenced this issue from a commit

2026-03-03 03:47:32 +00:00

Merge pull request 'fix: raise HTTPException in recalculate_standings on failure (#23)' (#41) from ai/major-domo-database-23 into main

cal added the

ai-working

label 2026-03-06 00:01:31 +00:00

cal commented

2026-03-06 00:02:45 +00:00

This fix was already implemented and merged via PR #41 (commit 4b288c1). The raise keyword is present at standings.py:124. Closing as resolved.