Eliminate N+1 queries in post_transactions #25

New Issue

cal · 2026-02-20T06:50:04Z

cal commented

2026-02-20 06:50:04 +00:00

app/routers_v3/transactions.py:126-133 — For each transaction in a batch, 3 individual DB queries validate teams and players. For a 50-move batch = 150 queries. Same pattern in post_results, post_schedules, post_batstats. All should use Team.id << [list] to fetch in a single query.

Priority: medium | Labels: performance

`app/routers_v3/transactions.py:126-133` — For each transaction in a batch, 3 individual DB queries validate teams and players. For a 50-move batch = 150 queries. Same pattern in `post_results`, `post_schedules`, `post_batstats`. All should use `Team.id << [list]` to fetch in a single query. **Priority**: medium | **Labels**: performance

cal added the

ai-working

label 2026-03-05 23:31:03 +00:00

cal referenced this issue from a commit

2026-03-05 23:33:41 +00:00

fix: eliminate N+1 queries in batch POST endpoints (#25)

cal referenced this issue

2026-03-05 23:33:57 +00:00

fix: eliminate N+1 queries in batch POST endpoints (#25) #52

cal removed the

ai-working

label 2026-03-05 23:34:04 +00:00

cal commented

2026-03-05 23:34:08 +00:00

PR #52 addresses this: #52

Fix approach: Before the validation loop in each endpoint, all required IDs are collected into sets and fetched with a single WHERE id IN (...) query. The loop then checks membership in the resulting Python sets instead of issuing a DB query per row.

post_transactions: 3N → 2 queries (team IDs + player IDs)
post_results / post_schedules: 2N → 1 query (combined away+home team IDs)
post_batstats: 2N → 2 queries (team IDs + player IDs)

PR #52 addresses this: https://git.manticorum.com/cal/major-domo-database/pulls/52 **Fix approach:** Before the validation loop in each endpoint, all required IDs are collected into sets and fetched with a single `WHERE id IN (...)` query. The loop then checks membership in the resulting Python sets instead of issuing a DB query per row. - `post_transactions`: 3N → 2 queries (team IDs + player IDs) - `post_results` / `post_schedules`: 2N → 1 query (combined away+home team IDs) - `post_batstats`: 2N → 2 queries (team IDs + player IDs)

cal added the

ai-pr-opened

label 2026-03-05 23:34:12 +00:00

cal referenced this issue from a commit

2026-03-10 14:37:58 +00:00

Merge pull request 'fix: eliminate N+1 queries in batch POST endpoints (#25)' (#52) from ai/major-domo-database-25 into next-release

cal closed this issue

2026-03-10 18:26:16 +00:00

cal referenced this issue from a commit

2026-03-17 21:31:32 +00:00

fix: eliminate N+1 queries in batch POST endpoints (#25)

cal referenced this issue