Fix ignored order_by() call in stratgame.py #24

New Issue

cal · 2026-02-20T06:49:58Z

cal commented

2026-02-20 06:49:58 +00:00

app/routers_v3/stratgame.py:94-97 — Peewee's order_by() returns a new queryset; it does not sort in place. Both branches discard the return value. Games are never sorted in GET /api/v3/games regardless of the sort parameter.

Priority: high | Labels: bug

`app/routers_v3/stratgame.py:94-97` — Peewee's `order_by()` returns a new queryset; it does not sort in place. Both branches discard the return value. Games are never sorted in `GET /api/v3/games` regardless of the `sort` parameter. **Priority**: high | **Labels**: bug

cal referenced this issue from a commit

2026-03-03 01:03:25 +00:00

fix: assign order_by() return value in GET /api/v3/games (#24)

cal referenced a pull request that will close this issue

2026-03-03 01:03:32 +00:00

fix: assign order_by() return value in GET /api/v3/games (#24) #39

cal commented

2026-03-03 01:03:40 +00:00

Fixed in PR #39.

Root cause: order_by() in Peewee returns a new queryset — it does not mutate in place. Both branches were calling all_games.order_by(...) without assigning the result back, so the ORDER BY clause was silently discarded and games were always returned in insertion order.

Fix: changed both branches to all_games = all_games.order_by(...) in app/routers_v3/stratgame.py.

Fixed in PR #39. Root cause: `order_by()` in Peewee returns a new queryset — it does not mutate in place. Both branches were calling `all_games.order_by(...)` without assigning the result back, so the ORDER BY clause was silently discarded and games were always returned in insertion order. Fix: changed both branches to `all_games = all_games.order_by(...)` in `app/routers_v3/stratgame.py`.

cal closed this issue

2026-03-03 01:29:29 +00:00

cal referenced this issue from a commit

2026-03-03 01:29:29 +00:00

Merge pull request 'fix: assign order_by() return value in GET /api/v3/games (#24)' (#39) from ai/major-domo-database-24 into main

Sign in to join this conversation.