fix: remove debug print() statements from gameplay_models.py (#32) #63

cal · 2026-03-05T13:03:30Z

cal commented

2026-03-05 13:03:30 +00:00

Summary

Deleted select_speed_testing() (lines 1318–1337) and select_all_testing() (lines 1340–1344) — both were dead code containing 5 print() calls that wrote directly to stdout
Both functions were already commented out in main() and had no other callers
Ruff auto-reformatted the file (same as PRs #60, #61, #62)

Files Changed

in_game/gameplay_models.py — removed two dead debug functions

Other observations

select_specic_fields() at line 1347 is also commented-out dead code (pre-existing, out of scope)

Test Results

No test suite configured for this repo.

## Summary - Deleted `select_speed_testing()` (lines 1318–1337) and `select_all_testing()` (lines 1340–1344) — both were dead code containing 5 `print()` calls that wrote directly to stdout - Both functions were already commented out in `main()` and had no other callers - Ruff auto-reformatted the file (same as PRs #60, #61, #62) ## Files Changed - `in_game/gameplay_models.py` — removed two dead debug functions ## Other observations - `select_specic_fields()` at line 1347 is also commented-out dead code (pre-existing, out of scope) ## Test Results No test suite configured for this repo.

cal added 1 commit 2026-03-05 13:03:30 +00:00

fix: remove debug print() statements from gameplay_models.py (#32 )

Build Docker Image / build (pull_request) Successful in 1m14s

Details

8c11ae81bc

Deleted select_speed_testing() and select_all_testing() — dead code that
only printed to stdout. Both functions were already commented out in main().

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cal referenced this pull request

2026-03-05 13:03:38 +00:00

Remove debug `print()` statements from `gameplay_models.py` #32

cal added the

ai-reviewing

label 2026-03-05 13:15:33 +00:00

cal reviewed 2026-03-05 13:16:22 +00:00

cal left a comment

AI Code Review

Files Reviewed

in_game/gameplay_models.py (modified)

Findings

Correctness

Grep confirms select_speed_testing() and select_all_testing() have no live callers anywhere in the codebase — only commented-out references in main() at lines 1357–1358. Deletions are safe.
Both deleted functions are correctly identified as dead code: they were never called at runtime and contained only print() statements writing to stdout.
The removed functions had no side effects beyond stdout output, so no behavior is changed by their removal.

Security

No issues. Removing debug output reduces information disclosure risk (e.g., print(f'Game: {game_1}') leaking ORM object repr to stdout in production contexts).

Style & Conventions

Ruff auto-reformatted the file, consistent with PRs #60, #61, #62. No logic changes from reformatting.
Pre-existing dead code (select_specic_fields() commented out at line 1347) correctly noted as out of scope.

Suggestions

select_specic_fields() at ~line 1347 is also dead commented code and could be cleaned up in a follow-up PR.

Verdict: APPROVED

Clean, minimal scope dead-code removal. Both functions confirmed to have no callers, PR description accurately describes the change.

Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `in_game/gameplay_models.py` (modified) ### Findings #### Correctness - Grep confirms `select_speed_testing()` and `select_all_testing()` have no live callers anywhere in the codebase — only commented-out references in `main()` at lines 1357–1358. Deletions are safe. - Both deleted functions are correctly identified as dead code: they were never called at runtime and contained only `print()` statements writing to stdout. - The removed functions had no side effects beyond stdout output, so no behavior is changed by their removal. #### Security - No issues. Removing debug output reduces information disclosure risk (e.g., `print(f'Game: {game_1}')` leaking ORM object repr to stdout in production contexts). #### Style & Conventions - Ruff auto-reformatted the file, consistent with PRs #60, #61, #62. No logic changes from reformatting. - Pre-existing dead code (`select_specic_fields()` commented out at line 1347) correctly noted as out of scope. #### Suggestions - `select_specic_fields()` at ~line 1347 is also dead commented code and could be cleaned up in a follow-up PR. ### Verdict: APPROVED Clean, minimal scope dead-code removal. Both functions confirmed to have no callers, PR description accurately describes the change. --- *Automated review by Claude PR Reviewer*

cal added

ai-reviewed

and removed

ai-reviewing

labels 2026-03-05 13:16:51 +00:00

cal changed target branch from main to next-release

2026-03-07 07:32:40 +00:00

cal force-pushed ai/paper-dynasty-discord-32 from 8c11ae81bc to 74b43ea369

2026-03-07 07:33:50 +00:00

Compare

cal changed target branch from next-release to main

2026-03-23 04:14:25 +00:00