fix: replace bare except: with typed NoResultFound in gameplay_queries (#25) #61

cal · 2026-03-05T12:03:44Z

cal commented

2026-03-05 12:03:44 +00:00

Summary

Replaces all 10 bare except: clauses in in_game/gameplay_queries.py with except sqlalchemy.exc.NoResultFound:.

Added import sqlalchemy to imports (consistent with cogs/gameplay.py which uses the same pattern)
Replaced bare except: at original lines 127, 238, 310, 333, 356, 447, 470, 493, 702, 811

What was fixed

Bare except: clauses catch all exceptions including KeyboardInterrupt, SystemExit, and GeneratorExit — not just the expected "no result" case. All affected blocks surround .one() calls which raise sqlalchemy.exc.NoResultFound when no row is found. Using a typed exception ensures unrelated errors propagate correctly.

Files changed

in_game/gameplay_queries.py

Test results

No test suite (per CLAUDE.md). Changes verified by code review.

Other observations

The ruff linter auto-formatted the file when the edit was saved (reformatted long import lines, standardized quote style, etc.). The cosmetic diff is larger than the functional change as a result, but no logic was altered beyond the import and except clause replacements.

## Summary Replaces all 10 bare `except:` clauses in `in_game/gameplay_queries.py` with `except sqlalchemy.exc.NoResultFound:`. - Added `import sqlalchemy` to imports (consistent with `cogs/gameplay.py` which uses the same pattern) - Replaced bare `except:` at original lines 127, 238, 310, 333, 356, 447, 470, 493, 702, 811 ## What was fixed Bare `except:` clauses catch **all** exceptions including `KeyboardInterrupt`, `SystemExit`, and `GeneratorExit` — not just the expected "no result" case. All affected blocks surround `.one()` calls which raise `sqlalchemy.exc.NoResultFound` when no row is found. Using a typed exception ensures unrelated errors propagate correctly. ## Files changed - `in_game/gameplay_queries.py` ## Test results No test suite (per CLAUDE.md). Changes verified by code review. ## Other observations The ruff linter auto-formatted the file when the edit was saved (reformatted long import lines, standardized quote style, etc.). The cosmetic diff is larger than the functional change as a result, but no logic was altered beyond the `import` and `except` clause replacements.

cal added 1 commit 2026-03-05 12:03:45 +00:00

fix: replace bare except: with typed NoResultFound in gameplay_queries (#25 )

Build Docker Image / build (pull_request) Successful in 1m17s

Details

2fac9f38dc

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cal referenced this pull request

2026-03-05 12:03:54 +00:00

Replace bare `except:` clauses with typed exception handling in `gameplay_queries.py` #25

cal added the

ai-reviewing

label 2026-03-05 12:15:32 +00:00

cal reviewed 2026-03-05 12:17:35 +00:00

cal left a comment

AI Code Review

Files Reviewed

in_game/gameplay_queries.py (modified)

Findings

Correctness

All 10 bare except: clauses are replaced with except sqlalchemy.exc.NoResultFound:. Count verified against the PR description.
sqlalchemy.exc.NoResultFound is the correct exception — it is raised by session.exec(...).one() when no row matches.
import sqlalchemy is added at the top of the file, consistent with the existing pattern in cogs/gameplay.py:13.
One nuance worth noting: the try blocks contain more than just the .one() call — they also include the update path (setattr, session.add, session.commit, session.refresh). Previously, a session.commit() failure during an update would be silently swallowed by the bare except: and fall through to the insert path, masking the real error. With the typed exception, those commit failures will now correctly propagate up. This is strictly better behavior, though the PR description undersells it by framing the blocks as just "surrounding .one() calls."

Security

No issues found.

Style & Conventions

Ruff auto-reformatted the file on save (multi-line imports, double quotes, trailing whitespace). No logic was changed by the formatter. The cosmetic diff is benign.
Import order: import sqlalchemy is placed before import pydantic in the new code. Ruff accepted this, so no issue.

Suggestions

None that would block merging.

Verdict: APPROVED

Clean fix for a real bug class. The exception narrowing is correct and the behavioral change (surfacing previously-swallowed update-path errors) is an improvement. Cosmetic ruff changes are harmless. Ready to merge.

Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `in_game/gameplay_queries.py` (modified) ### Findings #### Correctness - All 10 bare `except:` clauses are replaced with `except sqlalchemy.exc.NoResultFound:`. Count verified against the PR description. - `sqlalchemy.exc.NoResultFound` is the correct exception — it is raised by `session.exec(...).one()` when no row matches. - `import sqlalchemy` is added at the top of the file, consistent with the existing pattern in `cogs/gameplay.py:13`. - **One nuance worth noting:** the try blocks contain more than just the `.one()` call — they also include the update path (`setattr`, `session.add`, `session.commit`, `session.refresh`). Previously, a `session.commit()` failure during an update would be silently swallowed by the bare `except:` and fall through to the insert path, masking the real error. With the typed exception, those commit failures will now correctly propagate up. This is strictly better behavior, though the PR description undersells it by framing the blocks as just "surrounding `.one()` calls." #### Security - No issues found. #### Style & Conventions - Ruff auto-reformatted the file on save (multi-line imports, double quotes, trailing whitespace). No logic was changed by the formatter. The cosmetic diff is benign. - Import order: `import sqlalchemy` is placed before `import pydantic` in the new code. Ruff accepted this, so no issue. #### Suggestions - None that would block merging. ### Verdict: APPROVED Clean fix for a real bug class. The exception narrowing is correct and the behavioral change (surfacing previously-swallowed update-path errors) is an improvement. Cosmetic ruff changes are harmless. Ready to merge. --- *Automated review by Claude PR Reviewer*

cal added

ai-reviewed

and removed

ai-reviewing

labels 2026-03-05 12:18:03 +00:00

cal referenced this pull request

2026-03-05 13:03:30 +00:00

fix: remove debug print() statements from gameplay_models.py (#32) #63

cal changed target branch from main to next-release

2026-03-07 07:32:38 +00:00

cal force-pushed ai/paper-dynasty-discord-25 from 2fac9f38dc to c721d0a942

2026-03-07 07:33:36 +00:00