Commit Graph

2 Commits

Author SHA1 Message Date
Cal Corum
e6bd66ee39 CLAUDE: Fix game recovery for new GameState structure
Fixed state_manager._rebuild_state_from_data to provide required
current_batter field when recovering games from database. The GameState
model now requires current_batter as a LineupPlayerState object, but
recovery was not populating this field, causing validation errors.

Changes:
- state_manager.py: Create placeholder current_batter during recovery
  - Build LineupPlayerState from first active batter (batting_order=1)
  - Fallback to first available lineup if no #1 batter found
  - Raise error if no lineups exist (invalid game state)
  - _prepare_next_play() will correct the batter after recovery
  - Moved get_lineup_player helper to top of method (removed duplicate)

- tests/unit/core/test_state_manager.py: Update test to use new structure
  - test_update_state_nonexistent_raises_error: Create LineupPlayerState
    instead of using old current_batter_lineup_id field

All 26 state_manager unit tests passing. Game recovery now works
correctly in terminal client - fixes "current_batter Field required"
validation error when running status command on recovered games.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-04 15:26:00 -06:00
Cal Corum
9a9018aab4 CLAUDE: Migrate backend to UV package management
Migrated from pip to UV (v0.9.7) for faster, more reliable package management.

## Changes

### Package Management
- Created `pyproject.toml` with project metadata and dependencies
- Generated `uv.lock` for reproducible builds (198KB)
- Migrated all dependencies from requirements.txt:
  - Production: 20 packages (FastAPI, SQLAlchemy, Pydantic, etc.)
  - Development: 6 packages (pytest, black, mypy, flake8)
- Virtual environment moved from `venv/` to `.venv/` (UV default)

### Dockerfile Updates
- Updated base image: python:3.11-slim → python:3.13-slim
- Added UV installation via official image copy
- Development stage: Uses `uv sync --frozen` for all deps
- Production stage: Uses `uv sync --frozen --no-dev` for prod only
- Commands now use `uv run` prefix for auto-activation
- Set UV environment variables:
  - UV_LINK_MODE=copy (for Docker compatibility)
  - UV_COMPILE_BYTECODE=1 (performance)
  - UV_PYTHON_DOWNLOADS=never (use system Python)

### Code Fixes
- Fixed Pydantic model circular import in `app/models/game_models.py`
  - Added runtime import of PositionRating at end of file
  - Called `model_rebuild()` on LineupPlayerState and GameState
  - Resolves "not fully defined" errors in tests

### Documentation
- Updated `backend/CLAUDE.md` with UV usage:
  - Package management section with UV commands
  - Updated all code examples to use `uv run`
  - Daily development workflow now uses UV
  - Added dependency management guide (add/remove/update)
  - Updated virtual environment location (.venv/)

### Project Files
- Added `.python-version` (3.13) for UV Python version tracking
- Removed UV template files (main.py, README.md)
- Kept existing .gitignore (already includes venv/ and .venv/)

## Testing
-  All imports work correctly
-  55/55 game model tests passing
-  500+ unit tests passing (same as before migration)
-  Test failures are pre-existing (not UV-related)

## Benefits
- 10-100x faster dependency resolution
- 2-3x faster installation
- Better dependency conflict resolution
- Single tool for everything (replaces pip, pip-tools, virtualenv)
- Reproducible builds with uv.lock

## Migration Path for Team
```bash
# One-time: Install UV
curl -LsSf https://astral.sh/uv/install.sh | sh

# In project
cd backend
uv sync  # Creates .venv and installs everything

# Daily usage
uv run python -m app.main
uv run pytest tests/ -v
```

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-04 08:52:11 -06:00