cal/paper-dynasty-discord
1
0
Fork 0
Code Issues 14 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Fix play lock system to prevent permanent user lockouts #7

Merged
cal merged 3 commits from master into main 2026-02-04 15:27:35 +00:00
Conversation 0 Commits 3 Files Changed 6 +377 -166

3 Commits

Author SHA1 Message Date
cal
5233c04e17 Update VERSION
All checks were successful
Build Docker Image / build (pull_request) Successful in 1m15s
Details
2026-02-04 15:25:17 +00:00
Cal Corum
48c86e54fd Merge remote-tracking branch 'homelab/main'
Some checks failed
Build Docker Image / build (pull_request) Failing after 24s
Details
2026-02-04 09:24:15 -06:00
Cal Corum
ebf006e5c6 Fix play lock system to prevent permanent user lockouts 
CRITICAL BUG FIX: Play locks were never released on exceptions, causing
permanent user lockouts. Found 13 stuck plays in production.

Changes:
1. Added lock_play parameter to checks_log_interaction() (default True)
2. Removed unnecessary locks from read-only commands:
   - /settings-ingame (game settings, not play state)
   - /show-card defense (read-only display)
   - /substitute commands (just show UI, lock in callback)
3. Added safe_play_lock() context manager for automatic lock release
4. Added play locking to substitution callbacks:
   - SelectBatterSub.callback()
   - SelectReliefPitcher.callback()
5. Global error handler now releases stuck locks automatically

Architecture:
- Commands that display UI or read data: No lock
- Commands that modify play state: Lock at last possible moment
- 3-layer defense: manual release, context manager, global handler

Resolves race condition from concurrent play modifications.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
 2026-02-04 09:21:18 -06:00