Fix play lock system to prevent permanent user lockouts #7

cal · 2026-02-04T15:22:18Z

cal commented

2026-02-04 15:22:18 +00:00

CRITICAL BUG FIX: Play locks were never released on exceptions, causing
permanent user lockouts. Found 13 stuck plays in production.

Changes:

Added lock_play parameter to checks_log_interaction() (default True)
Removed unnecessary locks from read-only commands:
- /settings-ingame (game settings, not play state)
- /show-card defense (read-only display)
- /substitute commands (just show UI, lock in callback)
Added safe_play_lock() context manager for automatic lock release
Added play locking to substitution callbacks:
- SelectBatterSub.callback()
- SelectReliefPitcher.callback()
Global error handler now releases stuck locks automatically

Architecture:

Commands that display UI or read data: No lock
Commands that modify play state: Lock at last possible moment
3-layer defense: manual release, context manager, global handler

Resolves race condition from concurrent play modifications.

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

CRITICAL BUG FIX: Play locks were never released on exceptions, causing permanent user lockouts. Found 13 stuck plays in production. Changes: 1. Added lock_play parameter to checks_log_interaction() (default True) 2. Removed unnecessary locks from read-only commands: - /settings-ingame (game settings, not play state) - /show-card defense (read-only display) - /substitute commands (just show UI, lock in callback) 3. Added safe_play_lock() context manager for automatic lock release 4. Added play locking to substitution callbacks: - SelectBatterSub.callback() - SelectReliefPitcher.callback() 5. Global error handler now releases stuck locks automatically Architecture: - Commands that display UI or read data: No lock - Commands that modify play state: Lock at last possible moment - 3-layer defense: manual release, context manager, global handler Resolves race condition from concurrent play modifications. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

cal added 1 commit 2026-02-04 15:22:19 +00:00

Fix play lock system to prevent permanent user lockouts ebf006e5c6

CRITICAL BUG FIX: Play locks were never released on exceptions, causing
permanent user lockouts. Found 13 stuck plays in production.

Changes:
1. Added lock_play parameter to checks_log_interaction() (default True)
2. Removed unnecessary locks from read-only commands:
   - /settings-ingame (game settings, not play state)
   - /show-card defense (read-only display)
   - /substitute commands (just show UI, lock in callback)
3. Added safe_play_lock() context manager for automatic lock release
4. Added play locking to substitution callbacks:
   - SelectBatterSub.callback()
   - SelectReliefPitcher.callback()
5. Global error handler now releases stuck locks automatically

Architecture:
- Commands that display UI or read data: No lock
- Commands that modify play state: Lock at last possible moment
- 3-layer defense: manual release, context manager, global handler

Resolves race condition from concurrent play modifications.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

cal added 1 commit 2026-02-04 15:24:25 +00:00

Merge remote-tracking branch 'homelab/main'

Build Docker Image / build (pull_request) Failing after 24s

Details

48c86e54fd

cal added 1 commit 2026-02-04 15:25:20 +00:00

Update VERSION

Build Docker Image / build (pull_request) Successful in 1m15s

Details

5233c04e17

cal merged commit d181ee6201 into main

2026-02-04 15:27:35 +00:00