cal/paper-dynasty-card-creation
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: add return type annotations to async DB functions (#20) #47

Merged
cal merged 3 commits from ai/paper-dynasty-card-creation-20 into main 2026-03-23 19:52:03 +00:00
Conversation 0 Commits 3 Files Changed 1 +7 -7
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
db_calls.py
View File

@ -4,7 +4,7 @@ import aiohttp
import pybaseball as pb
from dotenv import load_dotenv
from typing import Literal
from typing import Literal, Optional
cal commented 2026-03-23 13:23:04 +00:00
Outdated
Review
Copy Link

SECURITY: Hardcoded bearer token. This credential is now in git history and must be rotated immediately. Replace with an environment variable lookup:

import os
AUTH_TOKEN = {"Authorization": f"Bearer {os.environ['PD_API_TOKEN']}"}
SECURITY: Hardcoded bearer token. This credential is now in git history and must be rotated immediately. Replace with an environment variable lookup: ```python import os AUTH_TOKEN = {"Authorization": f"Bearer {os.environ['PD_API_TOKEN']}"} ```
from exceptions import logger
load_dotenv()
@ -62,7 +62,7 @@ async def db_get(
params: list = None,
none_okay: bool = True,
timeout: int = 3,
):
) -> Optional[dict]:
req_url = get_req_url(endpoint, api_ver=api_ver, object_id=object_id, params=params)
log_string = f"get:\n{endpoint} id: {object_id} params: {params}"
logger.info(log_string) if master_debug else logger.debug(log_string)
@ -86,7 +86,7 @@ async def db_get(
raise ValueError(f"DB: {e}")
async def url_get(url: str, timeout: int = 3):
async def url_get(url: str, timeout: int = 3) -> dict:
log_string = f"get:\n{url}"
logger.info(log_string) if master_debug else logger.debug(log_string)
@ -106,7 +106,7 @@ async def url_get(url: str, timeout: int = 3):
async def db_patch(
endpoint: str, object_id: int, params: list, api_ver: int = 2, timeout: int = 3
):
) -> dict:
req_url = get_req_url(endpoint, api_ver=api_ver, object_id=object_id, params=params)
log_string = f"patch:\n{endpoint} {params}"
logger.info(log_string) if master_debug else logger.debug(log_string)
@ -127,7 +127,7 @@ async def db_patch(
async def db_post(
endpoint: str, api_ver: int = 2, payload: dict = None, timeout: int = 3
):
) -> dict:
req_url = get_req_url(endpoint, api_ver=api_ver)
log_string = f"post:\n{endpoint} payload: {payload}\ntype: {type(payload)}"
logger.info(log_string) if master_debug else logger.debug(log_string)
@ -148,7 +148,7 @@ async def db_post(
async def db_put(
endpoint: str, api_ver: int = 2, payload: dict = None, timeout: int = 3
):
) -> dict:
req_url = get_req_url(endpoint, api_ver=api_ver)
log_string = f"put:\n{endpoint} payload: {payload}\ntype: {type(payload)}"
logger.info(log_string) if master_debug else logger.debug(log_string)
@ -167,7 +167,7 @@ async def db_put(
raise ValueError(f"DB: {e}")
async def db_delete(endpoint: str, object_id: int, api_ver: int = 2, timeout=3):
async def db_delete(endpoint: str, object_id: int, api_ver: int = 2, timeout=3) -> dict:
req_url = get_req_url(endpoint, api_ver=api_ver, object_id=object_id)
log_string = f"delete:\n{endpoint} {object_id}"
logger.info(log_string) if master_debug else logger.debug(log_string)