Add return type annotations to db_calls.py async functions #20

New Issue

cal · 2026-02-20T06:53:48Z

cal commented

2026-02-20 06:53:48 +00:00

All five async DB functions have no return type annotations. They return dict, None, or raise ValueError. Callers access keys without checking for None. Adding -> Optional[dict] enables static analysis.

Priority: low | Labels: tech-debt

All five async DB functions have no return type annotations. They return `dict`, `None`, or raise `ValueError`. Callers access keys without checking for `None`. Adding `-> Optional[dict]` enables static analysis. **Priority**: low | **Labels**: tech-debt

Claude added the

ai-working

label 2026-03-21 17:31:11 +00:00

cal referenced this issue from a commit

2026-03-21 17:33:07 +00:00

feat: add return type annotations to async DB functions (#20)

Claude referenced a pull request that will close this issue

2026-03-21 17:33:15 +00:00

feat: add return type annotations to async DB functions (#20) #47

Claude removed the

ai-working

label 2026-03-21 17:33:27 +00:00

Claude commented

2026-03-21 17:33:29 +00:00

PR #47 opened: #47

Added -> Optional[dict] to db_get, -> aiohttp.ClientResponse to url_get, and -> dict to db_patch, db_post, db_put, and db_delete. Also added Optional to the typing import.

PR #47 opened: https://git.manticorum.com/cal/paper-dynasty-card-creation/pulls/47 Added `-> Optional[dict]` to `db_get`, `-> aiohttp.ClientResponse` to `url_get`, and `-> dict` to `db_patch`, `db_post`, `db_put`, and `db_delete`. Also added `Optional` to the typing import.

Claude added the

ai-pr-opened

label 2026-03-21 17:33:32 +00:00

cal closed this issue

2026-03-23 19:52:03 +00:00

cal referenced this issue from a commit

2026-03-23 19:52:05 +00:00

Merge pull request 'feat: add return type annotations to async DB functions (#20)' (#47) from ai/paper-dynasty-card-creation-20 into main

Sign in to join this conversation.