fix: remove test_positions_df non-test that always passes (#16) #43

Claude · 2026-03-21T07:02:21Z

Claude commented

2026-03-21 07:02:21 +00:00

Closes #16

Summary

test_positions_df in tests/test_helpers.py provided zero test coverage:

Called pd_positions_df(19) synchronously — this is an async function, so the call returned a coroutine object without executing any code
The result was stored but never examined
The only assertion was True == True, which always passes unconditionally

Changes

Removed test_positions_df function entirely
Removed the now-unused pd_positions_df import

pd_positions_df makes a live API call to the Paper Dynasty database; a proper test would require mocking db_get, which is out of scope for this cleanup.

Files changed

tests/test_helpers.py

Closes #16 ## Summary `test_positions_df` in `tests/test_helpers.py` provided zero test coverage: - Called `pd_positions_df(19)` synchronously — this is an `async` function, so the call returned a coroutine object without executing any code - The result was stored but never examined - The only assertion was `True == True`, which always passes unconditionally ## Changes - Removed `test_positions_df` function entirely - Removed the now-unused `pd_positions_df` import `pd_positions_df` makes a live API call to the Paper Dynasty database; a proper test would require mocking `db_get`, which is out of scope for this cleanup. ## Files changed - `tests/test_helpers.py`

Claude added 1 commit 2026-03-21 07:02:22 +00:00

fix: remove test_positions_df non-test that always passes (#16 ) 5b8d027d46

Closes #16

Deleted test_positions_df which called an async function synchronously
(returning a coroutine, not a DataFrame) and asserted True == True.
Zero coverage. Also removed the now-unused pd_positions_df import.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Claude referenced this pull request

2026-03-21 07:02:28 +00:00

Fix `test_positions_df` — non-test that always passes #16

Claude added the

ai-reviewing

label 2026-03-21 07:15:48 +00:00

Claude reviewed 2026-03-21 07:16:25 +00:00

Claude left a comment

AI Code Review

Files Reviewed

tests/test_helpers.py (modified)

Findings

Correctness

The PR description is accurate. pd_positions_df is an async function; calling it without await returns a coroutine object and executes no code. The result was assigned but never inspected, and the sole assertion (True == True) is unconditionally true — this was not a test in any meaningful sense.
The removal is clean: pd_positions_df is removed from the import, the dead function is gone, and the remaining two tests (test_mround, test_sanitize) are completely untouched.
No orphaned references remain.

Security

No issues found.

Style & Conventions

No issues found. The import line is now correctly minimal.

Suggestions

None. The PR does exactly what it says and nothing more.

Verdict: COMMENT (LGTM)

Clean removal of a non-functional test that provided zero coverage. The remaining tests are unaffected. Good housekeeping.

Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `tests/test_helpers.py` (modified) ### Findings #### Correctness - The PR description is accurate. `pd_positions_df` is an `async` function; calling it without `await` returns a coroutine object and executes no code. The result was assigned but never inspected, and the sole assertion (`True == True`) is unconditionally true — this was not a test in any meaningful sense. - The removal is clean: `pd_positions_df` is removed from the import, the dead function is gone, and the remaining two tests (`test_mround`, `test_sanitize`) are completely untouched. - No orphaned references remain. #### Security - No issues found. #### Style & Conventions - No issues found. The import line is now correctly minimal. #### Suggestions - None. The PR does exactly what it says and nothing more. ### Verdict: COMMENT (LGTM) Clean removal of a non-functional test that provided zero coverage. The remaining tests are unaffected. Good housekeeping. --- *Automated review by Claude PR Reviewer*

Claude added

ai-reviewed

and removed

ai-reviewing

labels 2026-03-21 07:16:49 +00:00

Claude added 1 commit 2026-03-23 03:51:03 +00:00

Merge branch 'main' into ai/paper-dynasty-card-creation-16 b55820eec8

cal approved these changes 2026-03-23 03:51:53 +00:00

cal left a comment

Approved — safe bug fix per PO triage.

Claude added 1 commit 2026-03-23 03:52:45 +00:00

Merge branch 'main' into ai/paper-dynasty-card-creation-16 230f3e79ce