Fix test_positions_df — non-test that always passes #16

New Issue

cal · 2026-02-20T06:53:28Z

cal commented

2026-02-20 06:53:28 +00:00

tests/test_helpers.py:4-7 — Calls an async function synchronously (will fail), but assertion is True == True. Variable never examined. Provides zero coverage.

Priority: low | Labels: tech-debt

`tests/test_helpers.py:4-7` — Calls an async function synchronously (will fail), but assertion is `True == True`. Variable never examined. Provides zero coverage. **Priority**: low | **Labels**: tech-debt

Claude referenced this issue

2026-03-20 19:34:04 +00:00

fix: add @pytest.mark.asyncio to async test methods (#21) #30

Claude added the

ai-working

label 2026-03-21 07:01:13 +00:00

cal referenced this issue from a commit

2026-03-21 07:02:15 +00:00

fix: remove test_positions_df non-test that always passes (#16)

Claude referenced a pull request that will close this issue

2026-03-21 07:02:21 +00:00

fix: remove test_positions_df non-test that always passes (#16) #43

Claude removed the

ai-working

label 2026-03-21 07:02:25 +00:00

Claude commented

2026-03-21 07:02:28 +00:00

Opened PR #43 to fix this: #43

Removed test_positions_df (called async pd_positions_df synchronously, asserted True == True) and the now-unused import. A real test would need db_get mocked, which is out of scope for this cleanup.

Opened PR #43 to fix this: https://git.manticorum.com/cal/paper-dynasty-card-creation/pulls/43 Removed `test_positions_df` (called async `pd_positions_df` synchronously, asserted `True == True`) and the now-unused import. A real test would need `db_get` mocked, which is out of scope for this cleanup.

Claude added the

ai-pr-opened

label 2026-03-21 07:02:31 +00:00

Claude closed this issue

2026-03-23 03:52:49 +00:00

Claude referenced this issue from a commit

2026-03-23 03:52:50 +00:00

Merge pull request 'fix: remove test_positions_df non-test that always passes (#16)' (#43) from ai/paper-dynasty-card-creation-16 into main

Sign in to join this conversation.