4cadb6566c
Removed outdated TODO comments and updated documentation to reflect work completed in Phase 3E (Position Ratings and WebSocket Handlers). Changes: - Removed 2 stale WebSocket emission TODOs in game_engine.py (lines 319, 387) These referenced Phase 3E-Final work completed on 2025-01-10 - Updated backend/CLAUDE.md Phase 3E status section Marked defender retrieval as COMPLETE (Phase 3E-Main) Clarified SPD test still pending (needs batter speed rating) Marked runner advancement as COMPLETE (Phase 3D) - Updated TODO_RESOLUTION_SUMMARY.md Marked defender lookup TODO as resolved with implementation details Documentation: - Created TODO_AUDIT_2025-01-14.md - Complete TODO audit (53 items) - Created TODO_VERIFICATION_RESULTS.md - Verification of resolved items - Created TODO_SUMMARY.md - Quick reference priority matrix - Created TODO_CLEANUP_COMPLETE.md - Cleanup work summary Test Status: - Backend: 9/9 PlayResolver tests passing - No regressions introduced Remaining Work: - 41 legitimate TODOs properly categorized for future phases - 8 Phase F6 TODOs (game page integration) - 5 Quick win TODOs (optional polish) - 28 Future phase TODOs (auth, AI, advanced features) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
97 lines
2.5 KiB
Markdown
97 lines
2.5 KiB
Markdown
# TODO Summary - Quick Reference
|
|
|
|
**Date**: 2025-01-14
|
|
**Status**: Post-Phase F5, Pre-Phase F6
|
|
|
|
---
|
|
|
|
## Quick Stats
|
|
|
|
| Category | Count | Priority |
|
|
|----------|-------|----------|
|
|
| **Stale Comments** (already done) | 12 | Clean up now |
|
|
| **Phase F6** (game integration) | 8 | Next sprint |
|
|
| **Quick Wins** (optional polish) | 5 | Optional |
|
|
| **Future Phases** (F7+, Phase 4, Week 9) | 28 | Defer |
|
|
| **TOTAL** | 53 | - |
|
|
|
|
---
|
|
|
|
## Priority Matrix
|
|
|
|
### 🔴 Priority 1: Clean Up Now (30 min)
|
|
**Already completed - just remove comments**
|
|
|
|
12 stale TODOs:
|
|
- 2 WebSocket emission comments (game_engine.py)
|
|
- Position ratings documentation update (CLAUDE.md)
|
|
- Defender lookup verification
|
|
- Update TODO_RESOLUTION_SUMMARY.md
|
|
|
|
**Why Now**: Avoid confusion, accurate documentation
|
|
|
|
---
|
|
|
|
### 🟡 Priority 2: Phase F6 Integration (6-8 hours)
|
|
**Critical for game lobby system**
|
|
|
|
8 TODOs:
|
|
- **Backend** (3): Game API endpoints (list/get/create)
|
|
- **Frontend** (5): Game page integration, lobby UI
|
|
|
|
**Why F6**: Core workflow for creating/joining games
|
|
|
|
---
|
|
|
|
### 🟢 Priority 3: Quick Wins (1 hour)
|
|
**Optional code polish**
|
|
|
|
5 TODOs:
|
|
- Remove unused config fields (strikes_for_out, balls_for_walk)
|
|
- Clean up outcome arrays
|
|
- Fix toast positioning
|
|
- Test data improvements
|
|
- Method naming refactor
|
|
|
|
**Why Optional**: Nice to have, not blocking
|
|
|
|
---
|
|
|
|
### ⚪ Priority 4: Future Phases (Defer)
|
|
**Not MVP critical**
|
|
|
|
28 TODOs:
|
|
- **Authorization** (10): WebSocket auth checks → Phase F7+
|
|
- **Authentication** (2): Discord OAuth → Phase F7+
|
|
- **AI Opponent** (6): Decision-making logic → Week 9
|
|
- **Advanced Gameplay** (5): Uncapped hits, interactive decisions → Phase 4+
|
|
- **SPD Test** (1): Batter speed rating → Phase 3E-Final or F6
|
|
- **Rare Play** (3): Define RP logic or accept placeholder → Decide
|
|
- **Statistics** (1): Earned runs calculation → Future
|
|
|
|
**Why Defer**: MVP works without these, add value later
|
|
|
|
---
|
|
|
|
## Detailed Breakdown
|
|
|
|
See full documents:
|
|
- **TODO_AUDIT_2025-01-14.md** - Complete audit with context
|
|
- **TODO_VERIFICATION_RESULTS.md** - Verification of resolved vs pending
|
|
|
|
---
|
|
|
|
## Recommended Next Actions
|
|
|
|
1. ✅ **Done**: TODO audit and verification complete
|
|
2. **Next**: Clean up 12 stale TODOs (~30 min)
|
|
3. **Then**: Proceed with Phase F6 integration (8 TODOs, 6-8 hours)
|
|
4. **Optional**: Quick wins if time permits (5 TODOs, 1 hour)
|
|
|
|
---
|
|
|
|
**Cal's Decision Point**:
|
|
- Start with Priority 1 cleanup now? (30 min)
|
|
- Skip cleanup and go straight to Phase F6? (your call)
|
|
- Do quick wins first? (optional 1 hour)
|