Commit Graph

3 Commits

Author SHA1 Message Date
Cal Corum
eab61ad966 CLAUDE: Phases 3.5, F1-F5 Complete - Statistics & Frontend Components
This commit captures work from multiple sessions building the statistics
system and frontend component library.

Backend - Phase 3.5: Statistics System
- Box score statistics with materialized views
- Play stat calculator for real-time updates
- Stat view refresher service
- Alembic migration for materialized views
- Test coverage: 41 new tests (all passing)

Frontend - Phase F1: Foundation
- Composables: useGameState, useGameActions, useWebSocket
- Type definitions and interfaces
- Store setup with Pinia

Frontend - Phase F2: Game Display
- ScoreBoard, GameBoard, CurrentSituation, PlayByPlay components
- Demo page at /demo

Frontend - Phase F3: Decision Inputs
- DefensiveSetup, OffensiveApproach, StolenBaseInputs components
- DecisionPanel orchestration
- Demo page at /demo-decisions
- Test coverage: 213 tests passing

Frontend - Phase F4: Dice & Manual Outcome
- DiceRoller component
- ManualOutcomeEntry with validation
- PlayResult display
- GameplayPanel orchestration
- Demo page at /demo-gameplay
- Test coverage: 119 tests passing

Frontend - Phase F5: Substitutions
- PinchHitterSelector, DefensiveReplacementSelector, PitchingChangeSelector
- SubstitutionPanel with tab navigation
- Demo page at /demo-substitutions
- Test coverage: 114 tests passing

Documentation:
- PHASE_3_5_HANDOFF.md - Statistics system handoff
- PHASE_F2_COMPLETE.md - Game display completion
- Frontend phase planning docs
- NEXT_SESSION.md updated for Phase F6

Configuration:
- Package updates (Nuxt 4 fixes)
- Tailwind config enhancements
- Game store updates

Test Status:
- Backend: 731/731 passing (100%)
- Frontend: 446/446 passing (100%)
- Total: 1,177 tests passing

Next Phase: F6 - Integration (wire all components into game page)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-14 09:52:30 -06:00
Cal Corum
0ebe72c09d CLAUDE: Phase 3F - Substitution System Testing Complete
This commit completes all Phase 3 work with comprehensive test coverage:

Test Coverage:
- 31 unit tests for SubstitutionRules (all validation paths)
- 10 integration tests for SubstitutionManager (DB + state sync)
- 679 total tests in test suite (609/609 unit tests passing - 100%)

Testing Scope:
- Pinch hitter validation and execution
- Defensive replacement validation and execution
- Pitching change validation and execution (min batters, force changes)
- Double switch validation
- Multiple substitutions in sequence
- Batting order preservation
- Database persistence verification
- State sync verification
- Lineup cache updates

All substitution system components are now production-ready:
 Core validation logic (SubstitutionRules)
 Orchestration layer (SubstitutionManager)
 Database operations
 WebSocket event handlers
 Comprehensive test coverage
 Complete documentation

Phase 3 Overall: 100% Complete
- Phase 3A-D (X-Check Core): 100%
- Phase 3E (Position Ratings + Redis): 100%
- Phase 3F (Substitutions): 100%

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-06 15:25:53 -06:00
Cal Corum
d142c7cac9 CLAUDE: Phase 2 test infrastructure + comprehensive documentation
Added Phase 2 test infrastructure for services layer with proper async
mocking patterns and comprehensive documentation of all test coverage work.

Documentation Added:
- TEST_COVERAGE_SUMMARY.md (comprehensive 600-line coverage report)
  * Complete Phase 1 & 2 analysis
  * 53 tests documented across all files
  * Metrics, patterns, and next steps

- tests/unit/services/ASYNC_MOCK_PATTERN.md
  * Proper httpx.AsyncClient async mocking pattern
  * Helper function setup_mock_http_client()
  * Clear examples and completion guide

Tests Added (Phase 2):
- tests/unit/services/test_pd_api_client.py (16 tests)
  * Test infrastructure created
  * Async mocking helper function established
  * 5/16 tests passing (initialization + request construction)
  * Pattern fix needed for 10 remaining tests (~20 min work)

Status:
- Phase 1: 32/37 tests passing (86%) 
- Phase 2: Framework established, async pattern documented 🔄
- Total: 53 tests added, 37 passing (70%)

Impact:
- Established best practices for async HTTP client mocking
- Created reusable helper function for service tests
- Documented all coverage work comprehensively
- Clear path to completion with <30 min remaining work

Next Steps (documented in ASYNC_MOCK_PATTERN.md):
1. Apply setup_mock_http_client() to 10 remaining tests
2. Fix catcher_id in rollback tests (4 tests)
3. Add position rating service tests (future)
4. Add WebSocket ConnectionManager tests (future)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-05 12:39:32 -06:00