9eb9669151
All checks were successful
Ruff Lint / lint (pull_request) Successful in 29s
Closes #149 Replaces fragile track_name string matching ('Pitcher' check) with the structured card_type field ('sp', 'rp', 'batter') already present in refractor API data. Prevents silent wrong-type renders when track_name varies ('Starting Pitcher', 'SP', etc.). Updates test fixtures and adds assertions that verify the correct card type URL segment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
77 lines
2.7 KiB
Python
77 lines
2.7 KiB
Python
"""Tests for post-game refractor card render trigger."""
|
|
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
|
|
from command_logic.logic_gameplay import _trigger_variant_renders
|
|
|
|
|
|
class TestTriggerVariantRenders:
|
|
"""Fire-and-forget card render calls after tier-ups."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_calls_render_url_for_each_tier_up(self):
|
|
"""Each tier-up with variant_created triggers a card render GET request.
|
|
|
|
card_type field ('sp', 'rp', 'batter') determines the render URL segment
|
|
('pitchingcard' or 'battingcard'). This prevents silent wrong-type renders
|
|
when track_name strings vary ('Pitcher', 'Starting Pitcher', 'SP', etc.).
|
|
"""
|
|
tier_ups = [
|
|
{"player_id": 100, "variant_created": 7, "card_type": "batter"},
|
|
{"player_id": 200, "variant_created": 3, "card_type": "sp"},
|
|
]
|
|
|
|
with patch(
|
|
"command_logic.logic_gameplay.db_get", new_callable=AsyncMock
|
|
) as mock_get:
|
|
mock_get.return_value = None
|
|
await _trigger_variant_renders(tier_ups)
|
|
|
|
assert mock_get.call_count == 2
|
|
call_args_list = [call.args[0] for call in mock_get.call_args_list]
|
|
assert any(
|
|
"100" in url and "battingcard" in url and "7" in url
|
|
for url in call_args_list
|
|
)
|
|
assert any(
|
|
"200" in url and "pitchingcard" in url and "3" in url
|
|
for url in call_args_list
|
|
)
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_skips_tier_ups_without_variant(self):
|
|
"""Tier-ups without variant_created are skipped."""
|
|
tier_ups = [
|
|
{"player_id": 100, "card_type": "batter"},
|
|
]
|
|
|
|
with patch(
|
|
"command_logic.logic_gameplay.db_get", new_callable=AsyncMock
|
|
) as mock_get:
|
|
await _trigger_variant_renders(tier_ups)
|
|
mock_get.assert_not_called()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_api_failure_does_not_raise(self):
|
|
"""Render trigger failures are swallowed — fire-and-forget."""
|
|
tier_ups = [
|
|
{"player_id": 100, "variant_created": 7, "card_type": "batter"},
|
|
]
|
|
|
|
with patch(
|
|
"command_logic.logic_gameplay.db_get", new_callable=AsyncMock
|
|
) as mock_get:
|
|
mock_get.side_effect = Exception("API down")
|
|
await _trigger_variant_renders(tier_ups)
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_empty_tier_ups_is_noop(self):
|
|
"""Empty tier_ups list does nothing."""
|
|
with patch(
|
|
"command_logic.logic_gameplay.db_get", new_callable=AsyncMock
|
|
) as mock_get:
|
|
await _trigger_variant_renders([])
|
|
mock_get.assert_not_called()
|