fix: variant render uses fragile track_name string mapping #149

New Issue

cal · 2026-04-08T00:23:52Z

cal commented

2026-04-08 00:23:52 +00:00

Problem

In _trigger_variant_renders() at logic_gameplay.py:4260-4261:

track = tier_up.get("track_name", "Batter")
card_type = "pitching" if track.lower() == "pitcher" else "batting"

This maps track names to card types via string check. If the API ever returns "Starting Pitcher", "SP", or any other variant, the mapping breaks silently and renders batting cards for pitchers. The default of "Batter" means any unexpected track name also gets treated as batting.

Fix

Use the track's card_type field (already available in refractor data as sp, rp, or batter) rather than the display-oriented track_name string.

Impact

Low effort fix. Prevents silent wrong-card-type renders.

## Problem In `_trigger_variant_renders()` at `logic_gameplay.py:4260-4261`: ```python track = tier_up.get("track_name", "Batter") card_type = "pitching" if track.lower() == "pitcher" else "batting" ``` This maps track names to card types via string check. If the API ever returns "Starting Pitcher", "SP", or any other variant, the mapping breaks silently and renders batting cards for pitchers. The default of "Batter" means any unexpected track name also gets treated as batting. ## Fix Use the track's `card_type` field (already available in refractor data as `sp`, `rp`, or `batter`) rather than the display-oriented `track_name` string. ## Impact Low effort fix. Prevents silent wrong-card-type renders.

Claude added the

ai-working

label 2026-04-08 03:31:20 +00:00

cal referenced this issue from a commit

2026-04-08 03:32:41 +00:00

fix: use card_type field instead of track_name string in variant renders (#149)

Claude referenced a pull request that will close this issue

2026-04-08 03:32:50 +00:00

fix: use card_type field instead of track_name string in variant renders (#149) #153

Claude commented

2026-04-08 03:33:01 +00:00

PR #153 opened: #153

Replaced track_name string matching with card_type field lookup (sp/rp → pitching, batter → batting). 2-line change in _trigger_variant_renders(). Test fixtures updated and assertions strengthened to verify the correct card type in the render URL.

PR #153 opened: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/153 Replaced `track_name` string matching with `card_type` field lookup (`sp`/`rp` → `pitching`, `batter` → `batting`). 2-line change in `_trigger_variant_renders()`. Test fixtures updated and assertions strengthened to verify the correct card type in the render URL.

Claude added the

ai-pr-opened

label 2026-04-08 03:33:05 +00:00

cal referenced this issue from a commit

2026-04-12 14:38:47 +00:00

fix: use card_type field instead of track_name string in variant renders (#149)

cal closed this issue

2026-04-12 14:39:51 +00:00

cal referenced this issue from a commit

2026-04-12 14:39:52 +00:00

Merge pull request 'fix: use card_type field instead of track_name string in variant renders (#149)' (#153) from issue/149-fix-variant-render-uses-fragile-track-name-string into main

Sign in to join this conversation.