fix: move health server from port 8080 to 8081 (#130) #131

Claude · 2026-03-26T04:33:23Z

Claude commented

2026-03-26 04:33:23 +00:00

Closes #130

What changed

Changed the health server default port from 8080 to 8081 to resolve the conflict with Adminer, which is mapped to host port 8080 in the docker-compose stack.

Files changed

health_server.py — default port changed to 8081 in both HealthServer.__init__ and run_health_server
CLAUDE.md — updated port references in Production and Common Issues sections
tests/refractor-integration-test-plan.md — updated health check URL references
tests/refractor-preflight.sh — updated curl health check URL

Deployment note

docker-compose.yml is gitignored and cannot be committed. The local dev file was updated manually (healthcheck URL → port 8081, added ports: 8081:8081). The production compose on sba-bots will also need its healthcheck updated:

healthcheck:
  test: ["CMD-SHELL", "python3 -c 'import urllib.request; urllib.request.urlopen(\"http://localhost:8081/health\", timeout=5)' || exit 1"]

And a port mapping added to expose the health endpoint from the host:

ports:
  - 8081:8081

Closes #130 ## What changed Changed the health server default port from **8080 to 8081** to resolve the conflict with Adminer, which is mapped to host port 8080 in the docker-compose stack. ## Files changed - `health_server.py` — default port changed to 8081 in both `HealthServer.__init__` and `run_health_server` - `CLAUDE.md` — updated port references in Production and Common Issues sections - `tests/refractor-integration-test-plan.md` — updated health check URL references - `tests/refractor-preflight.sh` — updated curl health check URL ## Deployment note `docker-compose.yml` is gitignored and cannot be committed. The local dev file was updated manually (healthcheck URL → port 8081, added `ports: 8081:8081`). The production compose on `sba-bots` will also need its healthcheck updated: ```yaml healthcheck: test: ["CMD-SHELL", "python3 -c 'import urllib.request; urllib.request.urlopen(\"http://localhost:8081/health\", timeout=5)' || exit 1"] ``` And a port mapping added to expose the health endpoint from the host: ```yaml ports: - 8081:8081 ```

Claude added 1 commit 2026-03-26 04:33:24 +00:00

fix: move health server from port 8080 to 8081 (#130 )

Ruff Lint / lint (pull_request) Successful in 22s

Details

035cd8888f

Adminer is exposed on host port 8080, shadowing the bot health endpoint.
Change health server default to 8081 to avoid the conflict.

Closes #130

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Claude referenced this pull request

2026-03-26 04:33:32 +00:00

Move bot health server off port 8080 to avoid Adminer conflict #130

Claude added the

ai-reviewing

label 2026-03-26 04:45:46 +00:00

Claude reviewed 2026-03-26 04:46:50 +00:00

Claude left a comment

AI Code Review

Files Reviewed

health_server.py (modified)
CLAUDE.md (modified)
tests/refractor-integration-test-plan.md (modified)
tests/refractor-preflight.sh (modified)

Findings

Correctness

Default port changed consistently in both HealthServer.__init__ (line 20) and run_health_server (line 151) — no split-brain risk.
Inline docstrings updated to match in both locations.
paperdynasty.py:137 calls run_health_server(bot) with no explicit port argument, so it inherits the new default (8081) automatically — no call-site changes needed.
All 8080 references in documentation and test artifacts are updated. Grep of the repo confirms no orphaned 8080 health-server references remain.

Security

No issues. Port number change has no security implications.

Style & Conventions

No issues. Change is minimal and consistent with project patterns.

Suggestions

The PR body correctly documents the manual docker-compose.yml steps required on sba-bots (healthcheck URL + port mapping). Consider adding a checklist item to the issue or a deployment runbook so the prod compose update doesn't get missed after merge.

Verdict: APPROVED

Clean, minimal, correct. All port references updated consistently across code, docs, and test artifacts. The paperdynasty.py call-site correctly inherits the new default without changes. Deployment note in the PR body is thorough.

(Note: Gitea blocks self-approval — posting as COMMENT. Treat as APPROVED.)

Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `health_server.py` (modified) - `CLAUDE.md` (modified) - `tests/refractor-integration-test-plan.md` (modified) - `tests/refractor-preflight.sh` (modified) ### Findings #### Correctness - Default port changed consistently in both `HealthServer.__init__` (line 20) and `run_health_server` (line 151) — no split-brain risk. - Inline docstrings updated to match in both locations. - `paperdynasty.py:137` calls `run_health_server(bot)` with no explicit port argument, so it inherits the new default (8081) automatically — no call-site changes needed. - All 8080 references in documentation and test artifacts are updated. Grep of the repo confirms no orphaned 8080 health-server references remain. #### Security - No issues. Port number change has no security implications. #### Style & Conventions - No issues. Change is minimal and consistent with project patterns. #### Suggestions - The PR body correctly documents the manual `docker-compose.yml` steps required on `sba-bots` (healthcheck URL + port mapping). Consider adding a checklist item to the issue or a deployment runbook so the prod compose update doesn't get missed after merge. ### Verdict: APPROVED Clean, minimal, correct. All port references updated consistently across code, docs, and test artifacts. The `paperdynasty.py` call-site correctly inherits the new default without changes. Deployment note in the PR body is thorough. *(Note: Gitea blocks self-approval — posting as COMMENT. Treat as APPROVED.)* --- *Automated review by Claude PR Reviewer*

Claude added

ai-reviewed

and removed

ai-reviewing

labels 2026-03-26 04:46:56 +00:00

Ruff Lint / lint (pull_request) Successful in 22s

Details

This pull request is blocked because it's outdated.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions.