fix: add explicit .gitignore entry for service-creds.json (#40) #43

cal · 2026-03-03T18:36:39Z

cal commented

2026-03-03 18:36:39 +00:00

Summary

Verified via git ls-files storage/ that no files in storage/ are currently tracked by git
Existing storage* pattern in .gitignore already prevents tracking of storage/paper-dynasty-service-creds.json
Added an explicit entry for storage/paper-dynasty-service-creds.json to make the protection intent unambiguous for this sensitive Google Sheets service credential file (referenced at cogs/gameplay.py:120)

Files Changed

.gitignore — added explicit entry for storage/paper-dynasty-service-creds.json

Test Results

No test suite. Verified via git ls-files storage/ (returns empty) and git check-ignore -v storage/paper-dynasty-service-creds.json would confirm coverage.

🤖 Generated with Claude Sonnet 4.6

## Summary - Verified via `git ls-files storage/` that no files in `storage/` are currently tracked by git - Existing `storage*` pattern in `.gitignore` already prevents tracking of `storage/paper-dynasty-service-creds.json` - Added an explicit entry for `storage/paper-dynasty-service-creds.json` to make the protection intent unambiguous for this sensitive Google Sheets service credential file (referenced at `cogs/gameplay.py:120`) ## Files Changed - `.gitignore` — added explicit entry for `storage/paper-dynasty-service-creds.json` ## Test Results No test suite. Verified via `git ls-files storage/` (returns empty) and `git check-ignore -v storage/paper-dynasty-service-creds.json` would confirm coverage. 🤖 Generated with Claude Sonnet 4.6

cal added 1 commit 2026-03-03 18:36:40 +00:00

fix: add explicit .gitignore entry for service-creds.json (#40 )

Build Docker Image / build (pull_request) Successful in 2m46s

Details

4f691d7aeb

Verified via `git ls-files storage/` that no storage files are tracked.
The existing `storage*` pattern already covers the directory, but adding
an explicit entry for `storage/paper-dynasty-service-creds.json` makes
the intent clear for this sensitive Google Sheets service credential file.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cal referenced this pull request

2026-03-03 18:36:50 +00:00

Ensure `storage/paper-dynasty-service-creds.json` is covered by `.gitignore` #40

cal added the

ai-reviewing

label 2026-03-03 19:01:31 +00:00

cal reviewed 2026-03-03 19:02:47 +00:00

cal left a comment

AI Code Review

Files Reviewed

.gitignore (modified)

Findings

Correctness

The new entry storage/paper-dynasty-service-creds.json is correctly formatted and functional.
As the PR body correctly notes, the existing storage* wildcard (line 133) already causes git to ignore the entire storage/ directory and all its contents, so this entry is technically redundant. However, redundancy here is intentional — it documents the specific sensitive file explicitly, which is sound defensive practice.
No ordering issues: both patterns ignore the file; there are no negation rules (!) that could cause a conflict.

Security

Positive change. storage/paper-dynasty-service-creds.json is a Google Sheets service account credential file referenced in cogs/gameplay.py. Making its exclusion explicit adds a layer of protection against accidental exposure if the storage* wildcard were ever removed.
No credentials, tokens, or secrets introduced in the diff.

Style & Conventions

Change is minimal and fits the existing "Project specifics" block convention.

Suggestions

None. The redundancy is justified for a sensitive file and follows defense-in-depth principles.

Verdict: APPROVED

Single-line .gitignore addition that explicitly protects a sensitive Google service credential file. Technically redundant with the existing storage* wildcard but adds meaningful clarity and defense-in-depth for a security-sensitive path. Clean, correct, and appropriately scoped.

Note: Gitea prevents self-approval — this review is posted as COMMENT but the verdict is APPROVED.

Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `.gitignore` (modified) ### Findings #### Correctness - The new entry `storage/paper-dynasty-service-creds.json` is correctly formatted and functional. - As the PR body correctly notes, the existing `storage*` wildcard (line 133) already causes git to ignore the entire `storage/` directory and all its contents, so this entry is technically redundant. However, redundancy here is intentional — it documents the specific sensitive file explicitly, which is sound defensive practice. - No ordering issues: both patterns ignore the file; there are no negation rules (`!`) that could cause a conflict. #### Security - Positive change. `storage/paper-dynasty-service-creds.json` is a Google Sheets service account credential file referenced in `cogs/gameplay.py`. Making its exclusion explicit adds a layer of protection against accidental exposure if the `storage*` wildcard were ever removed. - No credentials, tokens, or secrets introduced in the diff. #### Style & Conventions - Change is minimal and fits the existing "Project specifics" block convention. #### Suggestions - None. The redundancy is justified for a sensitive file and follows defense-in-depth principles. ### Verdict: APPROVED Single-line `.gitignore` addition that explicitly protects a sensitive Google service credential file. Technically redundant with the existing `storage*` wildcard but adds meaningful clarity and defense-in-depth for a security-sensitive path. Clean, correct, and appropriately scoped. > **Note:** Gitea prevents self-approval — this review is posted as COMMENT but the verdict is APPROVED. --- *Automated review by Claude PR Reviewer*

cal added

ai-reviewed

and removed

ai-reviewing

labels 2026-03-03 19:03:25 +00:00

cal merged commit 4781ec11db into main

2026-03-03 22:09:10 +00:00

cal deleted branch ai/paper-dynasty-discord-40

2026-03-03 22:09:11 +00:00

cal referenced this issue from a commit

2026-03-03 22:09:12 +00:00

Merge pull request 'fix: add explicit .gitignore entry for service-creds.json (#40)' (#43) from ai/paper-dynasty-discord-40 into main