cal/paper-dynasty-discord
1
0
Fork 0
Code Issues 14 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Ensure storage/paper-dynasty-service-creds.json is covered by .gitignore #40

New Issue
Closed
opened 2026-02-20 06:52:50 +00:00 by cal · 1 comment
cal commented 2026-02-20 06:52:50 +00:00
Owner
Copy Link

cogs/gameplay.py:51 references this file. .gitignore has storage* which should cover it, but worth confirming it is not already tracked with git ls-files storage/.

`cogs/gameplay.py:51` references this file. `.gitignore` has `storage*` which should cover it, but worth confirming it is not already tracked with `git ls-files storage/`.
cal added the
security
 label 2026-02-20 06:52:50 +00:00
cal added the
ai-working
 label 2026-03-03 18:35:09 +00:00
cal removed the
ai-working
 label 2026-03-03 18:36:46 +00:00
cal commented 2026-03-03 18:36:50 +00:00
Author
Owner
Copy Link

Verified and fixed in PR #43.

Findings:

  • git ls-files storage/ returns empty — no storage files are tracked by git ✓
  • .gitignore already has storage* (line 133) which covers storage/paper-dynasty-service-creds.json ✓

Change made: Added an explicit storage/paper-dynasty-service-creds.json entry to .gitignore alongside the existing storage* pattern to make the protection intent unambiguous for this sensitive Google Sheets service credential file.

Verified and fixed in PR #43. **Findings:** - `git ls-files storage/` returns empty — no storage files are tracked by git ✓ - `.gitignore` already has `storage*` (line 133) which covers `storage/paper-dynasty-service-creds.json` ✓ **Change made:** Added an explicit `storage/paper-dynasty-service-creds.json` entry to `.gitignore` alongside the existing `storage*` pattern to make the protection intent unambiguous for this sensitive Google Sheets service credential file.
cal added the
ai-pr-opened
 label 2026-03-03 18:37:18 +00:00
cal closed this issue 2026-03-10 18:26:32 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working

   
ai-working

   
bug

   
enhancement

   
feature

New feature proposal

  
in-queue

Approved for development

  
performance

   
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
ai-working
bug
enhancement
feature
in-queue
performance
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-discord#40
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?