Remove or implement empty if len(resp) > 0: pass blocks in complete_game #38

New Issue

Removed both if len(resp) > 0: pass stubs and the now-unused resp = variable assignments. The db_post() calls now run without capturing the return value since it was never used.

Fixed in PR #71: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/71 Removed both `if len(resp) > 0: pass` stubs and the now-unused `resp =` variable assignments. The `db_post()` calls now run without capturing the return value since it was never used.

cal added the

ai-pr-opened

label 2026-03-06 05:35:04 +00:00

cal referenced this issue from a commit

2026-03-07 07:34:01 +00:00

fix: remove empty if-pass stubs after db_post calls in complete_game (#38)

cal referenced this issue from a commit

2026-03-23 04:23:20 +00:00

fix: batch cleanup — dead code, bare excepts, empty stubs (#25, #32, #37, #38)

cal referenced a pull request that will close this issue

2026-03-23 04:23:35 +00:00

fix: batch cleanup — dead code, bare excepts, empty stubs #104

cal commented

2026-03-23 04:23:57 +00:00

Addressed in PR #104. Removed two resp = await db_post(...) / if len(resp) > 0: pass patterns in command_logic/logic_gameplay.py — resp was captured but never used, and the if-pass block was a no-op.

Addressed in PR #104. Removed two `resp = await db_post(...) / if len(resp) > 0: pass` patterns in `command_logic/logic_gameplay.py` — `resp` was captured but never used, and the if-pass block was a no-op.

cal referenced this issue

2026-03-23 04:27:11 +00:00

fix: batch cleanup — dead code, bare excepts, empty stubs #104

Claude closed this issue

2026-03-23 04:27:46 +00:00

Sign in to join this conversation.