cal/paper-dynasty-discord
1
0
Fork 0
Code Issues 14 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Remove unused PLAYER_CACHE from api_calls.py #37

New Issue
Closed
opened 2026-02-20 06:52:32 +00:00 by cal · 2 comments
cal commented 2026-02-20 06:52:32 +00:00
Owner
Copy Link

api_calls.py:21 defines PLAYER_CACHE = {} that is never read or written. Actual cache is in in_game/data_cache.py:9. Misleading dead variable.

`api_calls.py:21` defines `PLAYER_CACHE = {}` that is never read or written. Actual cache is in `in_game/data_cache.py:9`. Misleading dead variable.
cal added the
tech-debt
 label 2026-02-20 06:52:32 +00:00
cal added the
ai-working
enhancement
 labels 2026-03-05 13:31:40 +00:00
cal commented 2026-03-05 13:32:26 +00:00
Author
Owner
Copy Link

Fixed in PR #64: #64

Removed PLAYER_CACHE = {} from api_calls.py:21. Confirmed via grep that this variable had no callers — it was purely dead code. The active cache in in_game/data_cache.py is unaffected.

Fixed in PR #64: https://git.manticorum.com/cal/paper-dynasty-discord/pulls/64 Removed `PLAYER_CACHE = {}` from `api_calls.py:21`. Confirmed via grep that this variable had no callers — it was purely dead code. The active cache in `in_game/data_cache.py` is unaffected.
cal added
ai-pr-opened
 and removed
ai-working
 labels 2026-03-05 13:32:35 +00:00
cal commented 2026-03-23 04:23:52 +00:00
Author
Owner
Copy Link

Addressed in PR #104. Removed PLAYER_CACHE = {} from api_calls.py — confirmed no other references to it in that file.

Addressed in PR #104. Removed `PLAYER_CACHE = {}` from `api_calls.py` — confirmed no other references to it in that file.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working

   
ai-working

   
bug

   
enhancement

   
feature

New feature proposal

  
in-queue

Approved for development

  
performance

   
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
ai-working
bug
enhancement
feature
in-queue
performance
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-discord#37
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?