cal/paper-dynasty-database
1
0
Fork 0
Code Issues 7 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

fix: remove dead roster fields from CSV in v1_cards_get_one (#37) #39

Closed
cal wants to merge 1 commits from ai/paper-dynasty-database-37 into main
pull from: ai/paper-dynasty-database-37
merge into: cal:main
Conversation 0 Commits 1 Files Changed 1 +129 -78
cal commented 2026-03-03 20:36:10 +00:00
Owner
Copy Link

Summary

Removes non-existent roster1, roster2, roster3 columns from the CSV output in v1_cards_get_one. Accessing this_card.roster1.name etc. raises AttributeError at runtime for any GET /api/v2/cards/{card_id}?csv=true request.

Files Changed

  • app/routers_v2/cards.py — removed roster1, roster2, roster3 from CSV header and data row

Fix

Before:

data_list = [
    ['id', 'player', 'team', 'pack', 'value', 'roster1', 'roster2', 'roster3'],
    [this_card.id, this_card.player, this_card.team.abbrev, this_card.pack, this_card.value,
     this_card.roster1.name, this_card.roster2.name, this_card.roster3.name]
]

After:

data_list = [
    ['id', 'player', 'team', 'pack', 'value'],
    [this_card.id, this_card.player, this_card.team.abbrev, this_card.pack, this_card.value]
]

Test Results

No test suite. Fix verified by code inspection — Card model in db_engine.py has no roster fields.

Notes

The ruff linter hook reformatted the entire file (single → double quotes, line wrapping) on save. The functional diff is only the removal of the three roster columns.

Other Observations

  • v1_cards_patch still accepts roster1_id, roster2_id, roster3_id query parameters that are silently ignored (no assignment to this_card). This is dead API surface worth cleaning up separately.
## Summary Removes non-existent `roster1`, `roster2`, `roster3` columns from the CSV output in `v1_cards_get_one`. Accessing `this_card.roster1.name` etc. raises `AttributeError` at runtime for any `GET /api/v2/cards/{card_id}?csv=true` request. ## Files Changed - `app/routers_v2/cards.py` — removed `roster1`, `roster2`, `roster3` from CSV header and data row ## Fix **Before:** ```python data_list = [ ['id', 'player', 'team', 'pack', 'value', 'roster1', 'roster2', 'roster3'], [this_card.id, this_card.player, this_card.team.abbrev, this_card.pack, this_card.value, this_card.roster1.name, this_card.roster2.name, this_card.roster3.name] ] ``` **After:** ```python data_list = [ ['id', 'player', 'team', 'pack', 'value'], [this_card.id, this_card.player, this_card.team.abbrev, this_card.pack, this_card.value] ] ``` ## Test Results No test suite. Fix verified by code inspection — `Card` model in `db_engine.py` has no roster fields. ## Notes The ruff linter hook reformatted the entire file (single → double quotes, line wrapping) on save. The functional diff is only the removal of the three roster columns. ## Other Observations - `v1_cards_patch` still accepts `roster1_id`, `roster2_id`, `roster3_id` query parameters that are silently ignored (no assignment to `this_card`). This is dead API surface worth cleaning up separately.
cal added 1 commit 2026-03-03 20:36:11 +00:00
fix: remove dead roster fields from CSV in v1_cards_get_one (#37)
All checks were successful
Build Docker Image / build (pull_request) Successful in 3m13s
Details
20cfcff9f9 
Accessing this_card.roster1.name etc. raises AttributeError at runtime
since the Card model has no roster fields. Removed roster1/2/3 from
both the CSV header and data row.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cal added the
ai-reviewing
 label 2026-03-03 20:46:33 +00:00
cal reviewed 2026-03-03 20:48:56 +00:00
cal left a comment
Author
Owner
Copy Link

AI Code Review

Files Reviewed

  • app/routers_v2/cards.py (modified)

Findings

Correctness

  • Fix is verified correct. Confirmed against db_engine.py: the Card model (line 472) declares only player, team, pack, and value as fields — no roster1, roster2, or roster3. The old this_card.roster1.name access was a guaranteed AttributeError on every GET /api/v2/cards/{card_id}?csv=true request.
  • The remaining CSV columns (id, player, team.abbrev, pack, value) are all valid fields on the Card model.
  • Note: this_card.player serializes as the Peewee model repr in CSV (e.g. <Player: 42>), not the player name. This is pre-existing behavior not introduced by this PR and is consistent with the same pattern in the non-CSV path.

Security

  • No issues. Auth is enforced consistently across all write endpoints.

Style & Conventions

  • The ruff reformatter converted single → double quotes and applied line-wrapping throughout the file. This is cosmetic, consistent, and expected given the project's linting hook. It does not affect functionality.

Suggestions

  • The PR correctly calls out v1_cards_patch (lines 332–337 of current main) still accepting roster1_id, roster2_id, roster3_id query parameters that silently no-op (Peewee ignores assignments to undeclared fields on save()). This is dead API surface but not a crash risk. Recommend tracking this as a follow-up issue.

Verdict: APPROVED

The functional fix is minimal, correct, and addresses a runtime crash. The ruff reformatting is noise but harmless. Safe to merge.

Automated review by Claude PR Reviewer (COMMENT posted — Gitea does not permit self-approval)

## AI Code Review ### Files Reviewed - `app/routers_v2/cards.py` (modified) ### Findings #### Correctness - **Fix is verified correct.** Confirmed against `db_engine.py`: the `Card` model (line 472) declares only `player`, `team`, `pack`, and `value` as fields — no `roster1`, `roster2`, or `roster3`. The old `this_card.roster1.name` access was a guaranteed `AttributeError` on every `GET /api/v2/cards/{card_id}?csv=true` request. - The remaining CSV columns (`id`, `player`, `team.abbrev`, `pack`, `value`) are all valid fields on the `Card` model. - Note: `this_card.player` serializes as the Peewee model repr in CSV (e.g. `<Player: 42>`), not the player name. This is pre-existing behavior not introduced by this PR and is consistent with the same pattern in the non-CSV path. #### Security - No issues. Auth is enforced consistently across all write endpoints. #### Style & Conventions - The ruff reformatter converted single → double quotes and applied line-wrapping throughout the file. This is cosmetic, consistent, and expected given the project's linting hook. It does not affect functionality. #### Suggestions - The PR correctly calls out `v1_cards_patch` (lines 332–337 of current `main`) still accepting `roster1_id`, `roster2_id`, `roster3_id` query parameters that silently no-op (Peewee ignores assignments to undeclared fields on `save()`). This is dead API surface but not a crash risk. Recommend tracking this as a follow-up issue. ### Verdict: APPROVED The functional fix is minimal, correct, and addresses a runtime crash. The ruff reformatting is noise but harmless. Safe to merge. --- *Automated review by Claude PR Reviewer (COMMENT posted — Gitea does not permit self-approval)*
cal added
ai-reviewed
 and removed
ai-reviewing
 labels 2026-03-03 20:49:25 +00:00
cal closed this pull request 2026-03-03 21:14:34 +00:00
All checks were successful
Build Docker Image / build (pull_request) Successful in 3m13s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ai-changes-requested

   
ai-failed

   
ai-merged

PR merged by AI ops agent

  
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-reviewing

   
ai-working

   
bug

   
enhancement

   
evolution

Card Evolution system

  
performance

   
phase-0

Render Pipeline Optimization

  
phase-1a

Schema & Data Foundation

  
phase-1b

API & Formula Engine

  
phase-1c

Bot Integration

  
phase-1d

Deployment

  
security

   
tech-debt

   
todo
No Label
ai-changes-requested
ai-failed
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-reviewing
ai-working
bug
enhancement
evolution
performance
phase-0
phase-1a
phase-1b
phase-1c
phase-1d
security
tech-debt
todo
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-database#39
No description provided.
Delete Branch "ai/paper-dynasty-database-37"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?