refactor: extract evaluate-game business logic from router to service layer (#202) #207

Open
Claude wants to merge 2 commits from issue/202-refactor-extract-evaluate-game-business-logic-from into main

2 Commits

Author SHA1 Message Date
Cal Corum
c61e7c1bd1 fix: address review feedback (#207)
- Move all lazy imports in refractor_service.py to module top level
  (CLAUDE.md: no lazy imports; no circular import risk exists)
- Restore animated_url in evaluate_game tier-up response for T3/T4
  (regression from stale branch base predating PR #208 merge)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-10 12:02:47 -05:00
Cal Corum
e8b1091d8a refactor: extract evaluate-game business logic from router to service layer (#202)
Closes #202

Adds app/services/refractor_service.py with two service functions:

- ensure_variant_cards: idempotent function that creates missing variant
  cards for all tiers up to a target, with partial failure handling and
  REFRACTOR_BOOST_ENABLED kill switch support.

- evaluate_and_boost: combines evaluate_card(dry_run=True) with
  ensure_variant_cards so both tier computation and variant-card creation
  happen in one testable call without HTTP round-trips.

Updates both router endpoints to use evaluate_and_boost:

- POST /cards/{card_id}/evaluate now calls evaluate_and_boost instead of
  evaluate_card directly, which also fixes the broken variant creation on
  the manual evaluate path (variant cards are now created when a tier-up
  is detected, not just recorded).

- POST /evaluate-game/{game_id} replaces ~55 lines of inline boost
  orchestration (boost_enabled flag, tier loop, partial failure tracking,
  card_type/track null checks) with a single evaluate_and_boost call.
  Response shape is unchanged.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-08 00:37:26 -05:00