fix: remove SQLite references from CLAUDE.md (#123) #127

Claude · 2026-03-23T05:02:05Z

Claude commented

2026-03-23 05:02:05 +00:00

Closes #123

Updates database/CLAUDE.md to reflect that both dev and prod environments are now PostgreSQL — no SQLite.

Changes

Line 3: "Peewee ORM with SQLite (WAL mode)" → "Peewee ORM with PostgreSQL"
Line 17: ORM bullet removes storage/pd_master.db path and WAL journaling detail
Line 45: DATABASE_TYPE (sqlite/postgresql) annotation simplified to just DATABASE_TYPE
Line 50: Removed "SQLite locking (dev) → WAL mode should prevent..." — not applicable to PostgreSQL

Files changed

CLAUDE.md

No tests — docs-only change.

Closes #123 Updates `database/CLAUDE.md` to reflect that both dev and prod environments are now PostgreSQL — no SQLite. ## Changes - Line 3: "Peewee ORM with SQLite (WAL mode)" → "Peewee ORM with PostgreSQL" - Line 17: ORM bullet removes `storage/pd_master.db` path and WAL journaling detail - Line 45: `DATABASE_TYPE (sqlite/postgresql)` annotation simplified to just `DATABASE_TYPE` - Line 50: Removed "SQLite locking (dev) → WAL mode should prevent..." — not applicable to PostgreSQL ## Files changed - `CLAUDE.md` No tests — docs-only change.

Claude added 1 commit 2026-03-23 05:02:06 +00:00

fix: remove SQLite references from CLAUDE.md (#123 )

Build Docker Image / build (pull_request) Successful in 8m15s

Details

30a6e003e8

Closes #123

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Claude referenced this pull request

2026-03-23 05:02:15 +00:00

Update database CLAUDE.md — remove SQLite references #123

Claude added the

ai-reviewing

label 2026-03-23 05:15:41 +00:00

Claude reviewed 2026-03-23 05:16:19 +00:00

Claude left a comment

PR Review — fix: remove SQLite references from CLAUDE.md (#123)

Verdict: APPROVED ✓ (posted as COMMENT — Gitea self-review restriction)

Summary

Docs-only change. All 4 modifications match the PR description exactly and are factually correct:

Change	Assessment
Line 3: SQLite (WAL mode) → PostgreSQL	✓ Correct — DB is PostgreSQL
Line 17: ORM bullet removes `storage/pd_master.db` + WAL detail	✓ Correct — path/journaling not applicable
Line 45: `DATABASE_TYPE (sqlite/postgresql)` → `DATABASE_TYPE`	✓ Correct — SQLite option removed
Line 50: SQLite locking issue removed	✓ Correct — not applicable to PostgreSQL

Verification

Consistency: The Environments table (lines 29–37) already correctly showed pd_postgres — this PR brings lines 3 and 17 into alignment with the rest of the file.
Context: This directly resolves the pre-existing staleness noted in PR #125 review ("CLAUDE.md line 3 says 'SQLite (WAL mode)' but DB is PostgreSQL").
Scope: Clean, focused diff — 5 lines removed/changed, exactly 1 file. No scope creep.
Branch target: Direct-to-main acceptable for pure docs changes with no Docker/API impact (precedent: PR #125).

Suggestion (non-blocking)

DATABASE_TYPE could include a hint about its current valid value (e.g. DATABASE_TYPE (postgresql)) to help developers who encounter the env var without context. Not a blocker — bare annotation is readable enough alongside the other Postgres-specific vars on the same line.

## PR Review — fix: remove SQLite references from CLAUDE.md (#123) **Verdict: APPROVED** ✓ (posted as COMMENT — Gitea self-review restriction) --- ### Summary Docs-only change. All 4 modifications match the PR description exactly and are factually correct: | Change | Assessment | |---|---| | Line 3: SQLite (WAL mode) → PostgreSQL | ✓ Correct — DB is PostgreSQL | | Line 17: ORM bullet removes `storage/pd_master.db` + WAL detail | ✓ Correct — path/journaling not applicable | | Line 45: `DATABASE_TYPE (sqlite/postgresql)` → `DATABASE_TYPE` | ✓ Correct — SQLite option removed | | Line 50: SQLite locking issue removed | ✓ Correct — not applicable to PostgreSQL | --- ### Verification - **Consistency**: The Environments table (lines 29–37) already correctly showed `pd_postgres` — this PR brings lines 3 and 17 into alignment with the rest of the file. - **Context**: This directly resolves the pre-existing staleness noted in PR #125 review ("CLAUDE.md line 3 says 'SQLite (WAL mode)' but DB is PostgreSQL"). - **Scope**: Clean, focused diff — 5 lines removed/changed, exactly 1 file. No scope creep. - **Branch target**: Direct-to-main acceptable for pure docs changes with no Docker/API impact (precedent: PR #125). --- ### Suggestion (non-blocking) `DATABASE_TYPE` could include a hint about its current valid value (e.g. `DATABASE_TYPE (postgresql)`) to help developers who encounter the env var without context. Not a blocker — bare annotation is readable enough alongside the other Postgres-specific vars on the same line.

cal approved these changes 2026-03-23 13:13:55 +00:00

Dismissed

cal left a comment

AI Code Review

Files Reviewed

CLAUDE.md (modified)

Findings

Correctness

The four targeted removals/replacements are accurate and consistent with each other:

Line 3: Tech stack description updated correctly.
Line 17: ORM bullet correctly drops the storage/pd_master.db path and WAL journaling detail, which are SQLite-specific.
Line 45: The (sqlite/postgresql) annotation on DATABASE_TYPE is removed. The env var itself is kept, which is correct — it still controls which backend the code initialises.
Line 50: The SQLite locking troubleshooting entry is removed. The remaining "DB connection errors" entry covers the PostgreSQL equivalent.

No other SQLite references remain in the changed file after this patch.

Security

No issues found. This is a documentation-only change with no code paths affected.

Style & Conventions

The changes are minimal and targeted. No new prose introduced — only existing SQLite-specific text removed or simplified.

One pre-existing issue noted for awareness (not introduced by this PR): Lines 55-58 of CLAUDE.md still describe the retired next-release staging branch workflow. The parent CLAUDE.md at the repo root explicitly states that pattern is retired and all work targets main directly. This is out of scope for this PR but worth a follow-up ticket.

Suggestions

The DATABASE_TYPE env var is preserved but its valid values are no longer documented. If sqlite is no longer a supported value, it may be worth a follow-up to clarify what valid values are (e.g., annotating it as DATABASE_TYPE (postgresql) or removing it from the env var list entirely if it is now hardcoded).

Verdict: APPROVED

All SQLite references addressed cleanly. The diff matches the PR description exactly, and the documentation now accurately reflects the all-PostgreSQL reality of the project. The suggestion above is minor and does not block merging.

Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `CLAUDE.md` (modified) ### Findings #### Correctness The four targeted removals/replacements are accurate and consistent with each other: - Line 3: Tech stack description updated correctly. - Line 17: ORM bullet correctly drops the `storage/pd_master.db` path and WAL journaling detail, which are SQLite-specific. - Line 45: The `(sqlite/postgresql)` annotation on `DATABASE_TYPE` is removed. The env var itself is kept, which is correct — it still controls which backend the code initialises. - Line 50: The SQLite locking troubleshooting entry is removed. The remaining "DB connection errors" entry covers the PostgreSQL equivalent. No other SQLite references remain in the changed file after this patch. #### Security No issues found. This is a documentation-only change with no code paths affected. #### Style & Conventions The changes are minimal and targeted. No new prose introduced — only existing SQLite-specific text removed or simplified. One pre-existing issue noted for awareness (not introduced by this PR): Lines 55-58 of `CLAUDE.md` still describe the retired `next-release` staging branch workflow. The parent `CLAUDE.md` at the repo root explicitly states that pattern is retired and all work targets `main` directly. This is out of scope for this PR but worth a follow-up ticket. #### Suggestions - The `DATABASE_TYPE` env var is preserved but its valid values are no longer documented. If `sqlite` is no longer a supported value, it may be worth a follow-up to clarify what valid values are (e.g., annotating it as `DATABASE_TYPE (postgresql)` or removing it from the env var list entirely if it is now hardcoded). ### Verdict: APPROVED All SQLite references addressed cleanly. The diff matches the PR description exactly, and the documentation now accurately reflects the all-PostgreSQL reality of the project. The suggestion above is minor and does not block merging. --- *Automated review by Claude PR Reviewer*

cal approved these changes 2026-03-23 13:24:32 +00:00

Dismissed

cal left a comment

Approved for merge — docs-only change, SQLite references correctly removed from CLAUDE.md.

cal removed the

ai-reviewing

label 2026-03-23 13:30:31 +00:00

cal approved these changes 2026-03-23 13:30:58 +00:00

Dismissed

cal left a comment

Approved for merge.

cal approved these changes 2026-03-23 13:32:07 +00:00

cal left a comment

Approved for merge.

cal merged commit 1b2f8a7302 into main

2026-03-23 13:32:16 +00:00

cal deleted branch ai/paper-dynasty-database#123

2026-03-23 13:32:16 +00:00

cal referenced this issue from a commit

2026-03-23 13:32:18 +00:00

Merge pull request 'fix: remove SQLite references from CLAUDE.md (#123)' (#127) from ai/paper-dynasty-database#123 into main

cal added the

ai-merged

label 2026-03-23 13:32:25 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-database#127