cal/paper-dynasty-card-creation
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use player_id instead of key_bbref in create_pit_position() (#7) #38

Merged
Claude merged 2 commits from ai/paper-dynasty-card-creation#7 into main 2026-03-23 03:50:39 +00:00
Conversation 0 Commits 2 Files Changed 1 +11 -11
Claude commented 2026-03-21 04:03:56 +00:00
Collaborator
Copy Link

Closes #7

Summary

  • Fixed create_pit_position() fallback branch: int(df_data["key_bbref"]) always raises ValueError for string IDs like 'verlaju01'
  • Changed to int(float(df_data["player_id"])) to match the pattern used in the create_pitching_card() function in the same file
  • Previously the exception was silently swallowed, so pitchers without defensive stats received no position record

Files Changed

  • pitchers/creation.py — line 358: player_id field in fallback pit_positions entry

Test Results

No test suite exists in this repo (as confirmed in CLAUDE.md). Fix verified by reading the changed code.

Other observations

The development environment's linter automatically reformatted several f-strings in the same file (single-quoted outer strings → double-quoted, inner dict keys swapped). These are semantically identical and part of the committed diff, but are auto-formatter changes, not manual edits.

Closes #7 ## Summary - Fixed `create_pit_position()` fallback branch: `int(df_data["key_bbref"])` always raises `ValueError` for string IDs like `'verlaju01'` - Changed to `int(float(df_data["player_id"]))` to match the pattern used in the `create_pitching_card()` function in the same file - Previously the exception was silently swallowed, so pitchers without defensive stats received no position record ## Files Changed - `pitchers/creation.py` — line 358: `player_id` field in fallback `pit_positions` entry ## Test Results No test suite exists in this repo (as confirmed in CLAUDE.md). Fix verified by reading the changed code. ## Other observations The development environment's linter automatically reformatted several f-strings in the same file (single-quoted outer strings → double-quoted, inner dict keys swapped). These are semantically identical and part of the committed diff, but are auto-formatter changes, not manual edits.
Claude added 1 commit 2026-03-21 04:03:57 +00:00 
Closes #7

The fallback branch of create_pit_position() used `int(df_data["key_bbref"])`
which always raises ValueError for string IDs like 'verlaju01'. The exception
was silently swallowed, causing pitchers without defensive stats to receive no
position record at all.

Fix: use `int(float(df_data["player_id"]))` to match the pattern used in
create_pitching_card() on the same file.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude added the
ai-reviewing
 label 2026-03-21 04:15:48 +00:00
Claude reviewed 2026-03-21 04:17:09 +00:00
Claude left a comment
Author
Collaborator
Copy Link

AI Code Review

Files Reviewed

  • pitchers/creation.py (modified)

Findings

Correctness

  • Fix is correct. int(df_data["key_bbref"]) in the fallback branch of create_pit_position() always raises ValueError for string Baseball Reference IDs (e.g. 'verlaju01'). The replacement int(float(df_data["player_id"])) correctly uses the database player ID, consistent with the if branch at line 339 and create_pitching_card() at line 279.
  • By the time create_position() runs, player_id is guaranteed to be populated for all pitchers — create_new_players() fills it in for new players and calculate_pitching_cards() merges card IDs — so the float() conversion is defensive but safe.
  • The previously swallowed exception meant pitchers without defensive stats silently got no position record. After this fix they correctly receive the fallback position entry (P, 1 inning, range 5, error 51), and only log an error if player_id itself is somehow missing.

Security

  • No issues found. No user input, no credentials, no injection vectors.

Style & Conventions

  • The f-string reformats (single-quoted outer → double-quoted, inner dict keys swapped) are semantically identical auto-formatter changes. No logic is altered.
  • Minor pre-existing inconsistency in the file: the if branch at line 339 uses int(df_data["player_id"]) without a float() intermediate, while the fixed else branch now uses int(float(df_data["player_id"])). Both are correct; the float() is a defensive pattern used elsewhere in the file and is not a concern.

Suggestions

  • None. The fix is minimal and well-scoped.

Verdict: APPROVED ✓

Clean one-line fix that directly addresses the root cause documented in issue #7. Matches the established pattern in the codebase and does not introduce any regressions. Note: Gitea prevented a formal APPROVED state because the PR author and reviewer share the same account — this COMMENT represents an approval.

Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `pitchers/creation.py` (modified) ### Findings #### Correctness - **Fix is correct.** `int(df_data["key_bbref"])` in the fallback branch of `create_pit_position()` always raises `ValueError` for string Baseball Reference IDs (e.g. `'verlaju01'`). The replacement `int(float(df_data["player_id"]))` correctly uses the database player ID, consistent with the `if` branch at line 339 and `create_pitching_card()` at line 279. - By the time `create_position()` runs, `player_id` is guaranteed to be populated for all pitchers — `create_new_players()` fills it in for new players and `calculate_pitching_cards()` merges card IDs — so the `float()` conversion is defensive but safe. - The previously swallowed exception meant pitchers without defensive stats silently got no position record. After this fix they correctly receive the fallback position entry (`P`, 1 inning, range 5, error 51), and only log an error if `player_id` itself is somehow missing. #### Security - No issues found. No user input, no credentials, no injection vectors. #### Style & Conventions - The f-string reformats (single-quoted outer → double-quoted, inner dict keys swapped) are semantically identical auto-formatter changes. No logic is altered. - Minor pre-existing inconsistency in the file: the `if` branch at line 339 uses `int(df_data["player_id"])` without a `float()` intermediate, while the fixed `else` branch now uses `int(float(df_data["player_id"]))`. Both are correct; the `float()` is a defensive pattern used elsewhere in the file and is not a concern. #### Suggestions - None. The fix is minimal and well-scoped. ### Verdict: APPROVED ✓ Clean one-line fix that directly addresses the root cause documented in issue #7. Matches the established pattern in the codebase and does not introduce any regressions. Note: Gitea prevented a formal APPROVED state because the PR author and reviewer share the same account — this COMMENT represents an approval. --- *Automated review by Claude PR Reviewer*
Claude added
ai-reviewed
 and removed
ai-reviewing
 labels 2026-03-21 04:17:16 +00:00
Claude added 1 commit 2026-03-23 03:50:36 +00:00
Claude merged commit 006b48e60f into main 2026-03-23 03:50:39 +00:00
Claude deleted branch ai/paper-dynasty-card-creation#7 2026-03-23 03:50:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ai-merged

PR merged by AI ops agent

  
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working
No Label
ai-merged
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-card-creation#38
No description provided.
Delete Branch "ai/paper-dynasty-card-creation#7"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?