Fix SLG formula in extracted card rating models #22

cal · 2026-02-26T13:48:08Z

cal commented

2026-02-26 13:48:08 +00:00

Summary

fix SLG weighting in BattingCardRatingsModel.calculate_rate_stats()
fix SLG weighting in PitchingCardRatingsModel.calculate_rate_stats()
add regression tests for both formulas in tests/test_rate_stats_formulas.py

Test Plan

python -m pytest tests/test_rate_stats_formulas.py -q
verified both new tests pass (2 passed)

## Summary - fix SLG weighting in `BattingCardRatingsModel.calculate_rate_stats()` - fix SLG weighting in `PitchingCardRatingsModel.calculate_rate_stats()` - add regression tests for both formulas in `tests/test_rate_stats_formulas.py` ## Test Plan - `python -m pytest tests/test_rate_stats_formulas.py -q` - verified both new tests pass (2 passed)

cal added 3 commits 2026-02-26 13:48:09 +00:00

Add FullCard/CardColumn/CardResult models and card builder pipeline a72abc01a3

- card_layout.py: Port PlayResult, PLAY_RESULTS, EXACT_CHANCES, get_chances(),
  CardResult, CardColumn, FullCard, FullBattingCard, FullPitchingCard from
  database/app/card_creation.py. card_output() uses col_* key names.
  get_chances() always returns Decimal to avoid float/Decimal type errors.

- batters/card_builder.py: Port get_batter_card_data() algorithm as
  build_batter_full_cards(ratings_vl, ratings_vr, offense_col, player_id, hand).
  assign_bchances() returns float tuples for compatibility with float-based
  BattingCardRatingsModel fields.

- pitchers/card_builder.py: Port get_pitcher_card_data() algorithm as
  build_pitcher_full_cards(). assign_pchances() returns float tuples.
  Includes card.add_fatigue() at end of each card iteration.

- batters/calcs_batter.py: Integrate card builder in get_batter_ratings().
  After computing raw ratings, call build_batter_full_cards() and merge
  9 col_* rendered column fields into each ratings dict. Lazy import to
  avoid circular dependency.

- pitchers/calcs_pitcher.py: Same integration for get_pitcher_ratings().

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Extract BattingCardRatingsModel and PitchingCardRatingsModel into models.py files 39c652e55c

Move each ratings model class (and, for batters, the helper functions it
depends on) into a dedicated models.py so that calcs_*.py can import from
card_builder.py at module level without circular imports.

- batters/models.py: BattingCardRatingsModel + bp_singles, wh_singles,
  one_singles, bp_homeruns, triples, two_doubles, hit_by_pitch, strikeouts,
  flyout_a, flyout_bq, flyout_b, groundball_a, groundball_c
- pitchers/models.py: PitchingCardRatingsModel (no helper deps needed)
- batters/calcs_batter.py: imports model + build_batter_full_cards at top
- pitchers/calcs_pitcher.py: imports model + build_pitcher_full_cards at top
- batters/card_builder.py: imports from batters.models
- pitchers/card_builder.py: imports from pitchers.models
- tests/test_batter_calcs.py: import bp_singles, wh_singles from batters.models

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Fix SLG formula drift in extracted rating models 2bf3a6cee7

The extracted batting and pitching models used malformed SLG equations that double-counted and omitted outcomes, skewing slash lines. Align formulas with canonical weighting and add regression tests to prevent recurrence.

Co-Authored-By: Claude GPT-5.3-Codex <noreply@anthropic.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

cal added 1 commit 2026-02-26 18:04:58 +00:00

Fix two bugs in pitcher card builder dispatch logic 32cadb1c49

Fix duplicate elif branch in HR overflow cascade that prevented
single_one from receiving excess chances, and reorder single_two
secondary dispatch to check flyout full_name before groundout
short_name to prevent false 'B' matches on fly ball results.
Also add missing new_ratings.flyout_cf_b increment.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

cal added 1 commit 2026-02-26 21:38:05 +00:00

Add offense_col resolver for retrosheet pipeline to fix 883 silent KeyErrors db3822565c

The FullCard migration requires offense_col and player_id on each player's
DataFrame row. The retrosheet pipeline calculates ratings before posting,
so both fields were missing — causing silent card layout builder failures.

Adds a three-tier resolution: CSV cache → API bulk fetch → deterministic
hash fallback. Also includes player_id fallback in both calcs modules.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

cal added 1 commit 2026-02-27 05:59:00 +00:00

Add FullCard migration status doc for session continuity 931416a7c7

Documents current branch state, what's built, what's left,
known bugs, and decision points so the next session can pick
up without re-investigating.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

cal merged commit a4e56f6062 into main

2026-03-03 21:59:07 +00:00

cal referenced this issue from a commit

2026-03-03 21:59:09 +00:00

Merge pull request 'Fix SLG formula in extracted card rating models' (#22) from feature/fullcard-migration into main

Sign in to join this conversation.

No reviewers