docs: refractor Phase 2 design validation spec #51

Merged
cal merged 2 commits from docs/refractor-phase2-validation-spec into main 2026-03-24 21:09:07 +00:00
Owner

Summary

  • Pre-implementation design validation spec for Refractor Phase 2 (rating boosts)
  • 7 test cases documenting scenarios that must be verified before and during Phase 2 implementation
  • Covers: 108-sum preservation, D20 probability impact, pipeline collision risk, rarity cap, RP achievability, position parity, cross-season accumulation

Test plan

  • Document reviewed against PRD chapters 03-07
  • Rarity ID values cross-referenced with codebase (rarity_thresholds.py, creation.py)
  • Milestone thresholds validated against simulator output

Phase 2 blockers identified

  • T4-7: Cross-season stat accumulation needs explicit design decision (accumulate vs reset)
  • T4-3: Pipeline collision between post_player_updates() and T4 rarity upgrade needs resolution strategy

🤖 Generated with Claude Code

## Summary - Pre-implementation design validation spec for Refractor Phase 2 (rating boosts) - 7 test cases documenting scenarios that must be verified before and during Phase 2 implementation - Covers: 108-sum preservation, D20 probability impact, pipeline collision risk, rarity cap, RP achievability, position parity, cross-season accumulation ## Test plan - [x] Document reviewed against PRD chapters 03-07 - [x] Rarity ID values cross-referenced with codebase (`rarity_thresholds.py`, `creation.py`) - [x] Milestone thresholds validated against simulator output ## Phase 2 blockers identified - **T4-7**: Cross-season stat accumulation needs explicit design decision (accumulate vs reset) - **T4-3**: Pipeline collision between `post_player_updates()` and T4 rarity upgrade needs resolution strategy 🤖 Generated with [Claude Code](https://claude.com/claude-code)
cal added 1 commit 2026-03-24 21:02:55 +00:00
Seven pre-implementation test cases covering: 108-sum invariant
preservation under profile-based boosts, D20 probability shift
magnitude at T4, pipeline collision risk between T4 rarity upgrade
and live-series post_player_updates, HoF rarity cap (non-contiguous
ID ladder), RP T1 achievability, SP/RP/batter T4 parity, and the
cross-season stat accumulation design decision that must be confirmed
before Phase 2 code is written.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cal added 1 commit 2026-03-24 21:07:25 +00:00
- Add rarity name cross-reference table in Background section mapping PRD
  display names (Replacement/Reserve/Starter/All-Star/MVP/Hall of Fame) to
  codebase names (Common/Bronze/Silver/Gold/Diamond/HoF) with IDs
- Fix T4-2: correct Gold OPS threshold from 0.700 to 0.900 (confirmed in
  rarity_thresholds.py); add note that 0.700 is the Bronze floor
- Fix T4-1: restate truncation invariant as a single precise assertion —
  sum(columns) == 108 - truncated_amount — instead of two independent checks
  that can both pass while the sum is wrong for unrelated reasons

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cal merged commit eaf4bdbd6c into main 2026-03-24 21:09:07 +00:00
cal deleted branch docs/refractor-phase2-validation-spec 2026-03-24 21:09:07 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/paper-dynasty-card-creation#51
No description provided.