fix: roster validation includes pending trades, fixes sWAR field #9

cal · 2026-02-16T04:50:25Z

cal commented

2026-02-16 04:50:25 +00:00

Summary

RosterValidation field fix: total_wara → total_sWAR in roster_service.py, fixing the /legal command's silent AttributeError failure
Pending trade awareness: Transaction embed and submit validation now pass next_week to validate_transaction() so roster projections include pending trades for next week (fixes CAN's reported issue)
Import cleanup: Moved lazy mid-file imports to top-level in views/transaction_embed.py
Test fixture fix: Dropadd integration test roster fixtures used wara=3.0+i*0.1 totaling ~100 sWAR, exceeding the 32.0 cap — flattened to wara=1.0

Test plan

All 902 tests pass (0 failures, 3 skipped)
Previously failing 4 dropadd integration tests now pass
Previously failing 2 transaction embed tests now pass
Verify /legal command works in production (no more AttributeError)
Verify /dropadd shows correct roster count when team has pending trades

🤖 Generated with Claude Code

## Summary - **RosterValidation field fix**: `total_wara` → `total_sWAR` in `roster_service.py`, fixing the `/legal` command's silent AttributeError failure - **Pending trade awareness**: Transaction embed and submit validation now pass `next_week` to `validate_transaction()` so roster projections include pending trades for next week (fixes CAN's reported issue) - **Import cleanup**: Moved lazy mid-file imports to top-level in `views/transaction_embed.py` - **Test fixture fix**: Dropadd integration test roster fixtures used `wara=3.0+i*0.1` totaling ~100 sWAR, exceeding the 32.0 cap — flattened to `wara=1.0` ## Test plan - [x] All 902 tests pass (0 failures, 3 skipped) - [x] Previously failing 4 dropadd integration tests now pass - [x] Previously failing 2 transaction embed tests now pass - [ ] Verify `/legal` command works in production (no more AttributeError) - [ ] Verify `/dropadd` shows correct roster count when team has pending trades 🤖 Generated with [Claude Code](https://claude.com/claude-code)

cal added 1 commit 2026-02-16 04:50:26 +00:00

fix: roster validation now includes pending trades and fixes sWAR field name

Build Docker Image / build (pull_request) Failing after 14s

Details

db0874f1ab

RosterValidation used total_wara instead of total_sWAR, causing /legal
to silently fail. Transaction embed and submit validation now pass
next_week to validate_transaction() so pending trades are included in
roster count projections. Moved lazy imports to top-level in
transaction_embed.py. Fixed dropadd integration test fixtures that
exceeded sWAR cap.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

cal added 1 commit 2026-02-16 04:54:01 +00:00

Update VERSION

Build Docker Image / build (pull_request) Failing after 1m1s

Details

1299d78c82

cal force-pushed bugfix/roster-validation-fixes from 1299d78c82 to f29cccd3ab

2026-02-16 04:57:35 +00:00

Compare

cal added 1 commit 2026-02-16 04:58:58 +00:00

Bump version to 2.29.9

Build Docker Image / build (pull_request) Successful in 1m21s

Details

c1ae955155

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

cal merged commit 4eddcd112f into main

2026-02-16 05:00:32 +00:00

cal deleted branch bugfix/roster-validation-fixes

2026-02-16 05:00:32 +00:00

cal referenced this issue from a commit

2026-02-16 05:00:33 +00:00

Merge pull request 'fix: roster validation includes pending trades, fixes sWAR field' (#9) from bugfix/roster-validation-fixes into main

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/major-domo-v2#9