cal/major-domo-v2
1
0
Fork 0
Code Issues 6 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix: show validation errors in trade embed Quick Status #70

Merged
cal merged 2 commits from fix/trade-embed-errors-and-cleanup into main 2026-03-08 16:29:07 +00:00
Conversation 0 Commits 2 Files Changed 2 +324 -263
cal commented 2026-03-08 16:22:07 +00:00
Owner
Copy Link

Summary

  • Quick Status field now lists each validation error and suggestion instead of just showing "X errors found"
  • Stripped all emoji from trade embed titles, field names, field values, button labels, and messages

Test plan

  • Initiate a trade with a roster violation and verify Quick Status shows the actual error text
  • Verify Validate Trade button still shows full validation report
  • Verify Submit Trade blocks illegal trades with descriptive errors
  • Confirm no emoji appear anywhere in the trade embed UI
## Summary - Quick Status field now lists each validation error and suggestion instead of just showing "X errors found" - Stripped all emoji from trade embed titles, field names, field values, button labels, and messages ## Test plan - [ ] Initiate a trade with a roster violation and verify Quick Status shows the actual error text - [ ] Verify Validate Trade button still shows full validation report - [ ] Verify Submit Trade blocks illegal trades with descriptive errors - [ ] Confirm no emoji appear anywhere in the trade embed UI
cal added 1 commit 2026-03-08 16:22:07 +00:00
fix: show actual validation errors in trade embed Quick Status
All checks were successful
Build Docker Image / build (pull_request) Successful in 1m17s
Details
abd3fbc095 
Quick Status previously only showed "X errors found" with no details.
Now lists each error and suggestion inline. Also stripped all emoji
from embed titles, field names, values, buttons, and messages.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cal added 1 commit 2026-03-08 16:25:38 +00:00
fix: trade validation now checks against next week's projected roster
All checks were successful
Build Docker Image / build (pull_request) Successful in 1m12s
Details
44929b418f 
validate_trade() was passing next_week=None to each team's
validate_transaction(), which skipped load_existing_transactions()
entirely. Trades were validated against the current roster only,
ignoring pending /dropadd transactions for next week.

Now auto-fetches current week from league_service and passes
next_week=current_week+1, matching /dropadd validation behavior.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cal force-pushed fix/trade-embed-errors-and-cleanup from 44929b418f to 58fe9f22de 2026-03-08 16:27:06 +00:00 Compare
cal merged commit b3b8cd9683 into main 2026-03-08 16:29:07 +00:00
cal deleted branch fix/trade-embed-errors-and-cleanup 2026-03-08 16:29:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ai-changes-requested

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-working

   
in-next-release

Fix included in the next-release branch, pending merge to main

  
status/in-progress

Work is actively in progress

  
status/pr-open

A pull request has been opened for this issue

No Label
ai-changes-requested
ai-pr-opened
ai-reviewed
ai-reviewing
ai-working
in-next-release
status/in-progress
status/pr-open
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/major-domo-v2#70
No description provided.
Delete Branch "fix/trade-embed-errors-and-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?