fix: key plays score text shows "tied at X" correctly (closes #48) #52

cal · 2026-03-01T21:37:06Z

cal commented

2026-03-01 21:37:06 +00:00

Summary

Fix logic bug in Play.descriptive_text() where tied scores displayed as "Team up X-X" instead of "tied at X"
The else branch caught both "away leading" and "tied" cases — changed to if/elif/else
Added tests/test_models_play.py with 5 tests covering tied, home-leading, and away-leading score scenarios

Test plan

All 5 new tests in test_models_play.py pass (tied at 0, tied via top-inning RBI, tied via bottom-inning RBI, home leading, away leading)
Full test suite passes (935 passed, 3 skipped)
Verify in Discord after deploy that key plays in post-game summaries show "tied at X" correctly

🤖 Generated with Claude Code

## Summary - Fix logic bug in `Play.descriptive_text()` where tied scores displayed as "Team up X-X" instead of "tied at X" - The `else` branch caught both "away leading" and "tied" cases — changed to `if/elif/else` - Added `tests/test_models_play.py` with 5 tests covering tied, home-leading, and away-leading score scenarios ## Test plan - [x] All 5 new tests in `test_models_play.py` pass (tied at 0, tied via top-inning RBI, tied via bottom-inning RBI, home leading, away leading) - [x] Full test suite passes (935 passed, 3 skipped) - [ ] Verify in Discord after deploy that key plays in post-game summaries show "tied at X" correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code)

cal added 2 commits 2026-03-01 21:37:07 +00:00

Merge pull request 'next-release' (#51 ) from next-release into main

Build Docker Image / build (push) Successful in 1m0s

Details

f7a65706a1

Reviewed-on: #51

fix: key plays score text shows "tied at X" instead of "Team up X-X" (closes #48 ) 0daa6f4491

The else branch in descriptive_text() caught both "away leading" and
"tied" cases, always overwriting the tied text. Changed to if/elif/else
so tied scores display correctly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

cal merged commit 98d47a1262 into next-release

2026-03-01 21:38:35 +00:00

cal referenced this issue from a commit

2026-03-01 21:38:35 +00:00

Merge pull request 'fix: key plays score text shows "tied at X" correctly (closes #48)' (#52) from fix/key-plays-tied-score into next-release

cal deleted branch fix/key-plays-tied-score

2026-03-01 21:38:35 +00:00

Sign in to join this conversation.

No reviewers