fix: roster validation includes org affiliate transactions #50

cal · 2026-03-01T16:45:56Z

cal commented

2026-03-01 16:45:56 +00:00

Summary

Fixes #49 — Team POR was getting a false "too many players" error when trying to move Jeffrey Springs from IL to MiL next week, despite a pending trade that would clear a MiL spot.

Root cause: load_existing_transactions() only queried for transactions matching the base team abbreviation (e.g., POR). The database API does exact matching on Team.abbrev, so trade transactions involving affiliates (PORMIL, PORIL) were invisible to roster validation.

Fix:

get_team_transactions() now accepts Union[str, List[str]] for team_abbrev
load_existing_transactions() queries all org affiliates: ["POR", "PORMIL", "PORIL"]

Changes

services/transaction_service.py — Accept list of abbreviations (backwards compatible)
services/transaction_builder.py — Query org affiliates in load_existing_transactions()
tests/test_roster_validation_org_affiliates.py — 5 new tests covering the exact POR scenario

Test plan

All 930 existing tests pass
5 new tests verify: org abbreviation querying, trade-clearing-MiL-spot scenario, baseline rejection without trade, list/string backwards compatibility

## Summary Fixes #49 — Team POR was getting a false "too many players" error when trying to move Jeffrey Springs from IL to MiL next week, despite a pending trade that would clear a MiL spot. **Root cause:** `load_existing_transactions()` only queried for transactions matching the base team abbreviation (e.g., `POR`). The database API does exact matching on `Team.abbrev`, so trade transactions involving affiliates (`PORMIL`, `PORIL`) were invisible to roster validation. **Fix:** - `get_team_transactions()` now accepts `Union[str, List[str]]` for `team_abbrev` - `load_existing_transactions()` queries all org affiliates: `["POR", "PORMIL", "PORIL"]` ## Changes - `services/transaction_service.py` — Accept list of abbreviations (backwards compatible) - `services/transaction_builder.py` — Query org affiliates in `load_existing_transactions()` - `tests/test_roster_validation_org_affiliates.py` — 5 new tests covering the exact POR scenario ## Test plan - [x] All 930 existing tests pass - [x] 5 new tests verify: org abbreviation querying, trade-clearing-MiL-spot scenario, baseline rejection without trade, list/string backwards compatibility

cal added 2 commits 2026-03-01 16:45:57 +00:00

Merge pull request 'next-release' (#47 ) from next-release into main

Build Docker Image / build (push) Successful in 46s

Details

a80addc742

Reviewed-on: #47

fix: roster validation now includes org affiliate transactions (closes #49 ) aa27769ed6

load_existing_transactions only queried for the base team abbreviation
(e.g. "POR"), missing trades involving MiL/IL affiliates ("PORMIL",
"PORIL"). This caused false "too many players" errors when a pending
trade would have cleared a roster spot.

- get_team_transactions now accepts Union[str, List[str]] for team_abbrev
- load_existing_transactions queries all org affiliates [BASE, BASEMiL, BASEIL]
- Added 5 tests covering the fix and backwards compatibility

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

cal merged commit 46afbf25e0 into next-release

2026-03-01 20:50:22 +00:00

cal deleted branch fix/roster-validation-org-affiliates

2026-03-01 20:50:22 +00:00

cal referenced this issue from a commit

2026-03-01 20:50:24 +00:00

Merge pull request 'fix: roster validation includes org affiliate transactions' (#50) from fix/roster-validation-org-affiliates into next-release

cal referenced this pull request

2026-03-01 20:52:02 +00:00

next-release #51

Sign in to join this conversation.

No reviewers