cal/major-domo-v2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix off-by-one error in draft recent picks display

Browse Source 
The get_recent_picks service method was subtracting 1 from overall_end,
but callers were already passing currentpick - 1. This caused the "Last 5
picks" list on the OnTheClock embed to skip the most recently completed
pick (showing picks 2-6 before current instead of 1-5).

Removed the extra subtraction in the service method since callers already
handle the exclusivity of the overall_end parameter.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Cal Corum 2025-12-12 19:14:53 -06:00
parent 95d18d603e
commit 1af7c82353
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
VERSION
View File

@ -1 +1 @@
2.24.5 2.24.6

2
services/draft_pick_service.py
View File

@ -276,7 +276,7 @@ class DraftPickService(BaseService[DraftPick]):
try: try:
params = [ params = [
('season', str(season)), ('season', str(season)),
('overall_end', str(overall_end - 1)), # Exclude current pick ('overall_end', str(overall_end)), # overall_end is already exclusive (caller passes currentpick - 1)
('player_taken', 'true'), # Only taken picks ('player_taken', 'true'), # Only taken picks
('sort', 'order-desc'), # Most recent first ('sort', 'order-desc'), # Most recent first
('limit', str(limit)) ('limit', str(limit))

4
tests/test_services_draft.py
View File

@ -794,7 +794,7 @@ class TestDraftPickService:
Test retrieving recently made picks. Test retrieving recently made picks.
Verifies: Verifies:
- overall_end is set to current-1 (exclude current pick) - overall_end is passed through directly (caller handles exclusivity)
- player_taken=true (only filled picks) - player_taken=true (only filled picks)
- sort=order-desc (most recent first) - sort=order-desc (most recent first)
- limit is applied - limit is applied
@ -810,7 +810,7 @@ class TestDraftPickService:
assert len(result) == 5 assert len(result) == 5
call_params = mock_client.get.call_args[1]['params'] call_params = mock_client.get.call_args[1]['params']
assert ('overall_end', '49') in call_params # 50 - 1 assert ('overall_end', '50') in call_params # Passed through directly
assert ('player_taken', 'true') in call_params assert ('player_taken', 'true') in call_params
assert ('sort', 'order-desc') in call_params assert ('sort', 'order-desc') in call_params
assert ('limit', '5') in call_params assert ('limit', '5') in call_params