From 1af7c823533cacf59faf324a1089aef7bf6dc936 Mon Sep 17 00:00:00 2001 From: Cal Corum Date: Fri, 12 Dec 2025 19:14:53 -0600 Subject: [PATCH] Fix off-by-one error in draft recent picks display MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The get_recent_picks service method was subtracting 1 from overall_end, but callers were already passing currentpick - 1. This caused the "Last 5 picks" list on the OnTheClock embed to skip the most recently completed pick (showing picks 2-6 before current instead of 1-5). Removed the extra subtraction in the service method since callers already handle the exclusivity of the overall_end parameter. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- VERSION | 2 +- services/draft_pick_service.py | 2 +- tests/test_services_draft.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/VERSION b/VERSION index 23a9383..c5f92d6 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -2.24.5 +2.24.6 diff --git a/services/draft_pick_service.py b/services/draft_pick_service.py index e7508a0..fecd61c 100644 --- a/services/draft_pick_service.py +++ b/services/draft_pick_service.py @@ -276,7 +276,7 @@ class DraftPickService(BaseService[DraftPick]): try: params = [ ('season', str(season)), - ('overall_end', str(overall_end - 1)), # Exclude current pick + ('overall_end', str(overall_end)), # overall_end is already exclusive (caller passes currentpick - 1) ('player_taken', 'true'), # Only taken picks ('sort', 'order-desc'), # Most recent first ('limit', str(limit)) diff --git a/tests/test_services_draft.py b/tests/test_services_draft.py index a3cc56e..13a0bf9 100644 --- a/tests/test_services_draft.py +++ b/tests/test_services_draft.py @@ -794,7 +794,7 @@ class TestDraftPickService: Test retrieving recently made picks. Verifies: - - overall_end is set to current-1 (exclude current pick) + - overall_end is passed through directly (caller handles exclusivity) - player_taken=true (only filled picks) - sort=order-desc (most recent first) - limit is applied @@ -810,7 +810,7 @@ class TestDraftPickService: assert len(result) == 5 call_params = mock_client.get.call_args[1]['params'] - assert ('overall_end', '49') in call_params # 50 - 1 + assert ('overall_end', '50') in call_params # Passed through directly assert ('player_taken', 'true') in call_params assert ('sort', 'order-desc') in call_params assert ('limit', '5') in call_params