cal/major-domo-database
1
0
Fork 0
Code Issues 25 Pull Requests 25 Actions Packages Projects Releases Wiki Activity

fix: Respect short_output parameter in player search endpoint #6

Merged
cal merged 2 commits from fix/player-search-respect-short-output into main 2026-02-06 02:11:23 +00:00
Conversation 0 Commits 2 Files Changed 2 +2 -2

2 Commits

Author SHA1 Message Date
cal
1216bec287 Update VERSION
All checks were successful
Build Docker Image / build (pull_request) Successful in 3m2s
Details
2026-02-06 02:08:02 +00:00
Cal Corum
39bc99b0dd fix: Respect short_output parameter in player search endpoint
Some checks failed
Build Docker Image / build (pull_request) Failing after 15s
Details 
The search_players() method was hardcoding short_output=True when
converting query results to dicts, ignoring the function parameter.
This caused the /api/v3/players/search endpoint to always return
team_id as an integer instead of nested team objects, even when
short_output=False was specified.

Impact:
- Discord bot's /injury clear command was crashing because
  player.team was None (only team_id was populated)
- Any code using search endpoint couldn't get full team data

Fix:
- Changed line 386 to use the short_output parameter value
- Now respects short_output parameter: False returns full team
  objects, True returns just team IDs

Root cause analysis from production logs:
- Error: AttributeError: 'NoneType' object has no attribute 'roster_type'
- Location: commands/injuries/management.py:647
- Cause: player.team was None after search_players() call

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
 2026-02-05 19:43:50 -06:00