cal/major-domo-database
1
0
Fork 0
Code Issues 25 Pull Requests 25 Actions Packages Projects Releases Wiki Activity

fix: remove unused imports in standings.py and pitchingstats.py (#30) #49

Merged
cal merged 1 commits from ai/major-domo-database-30 into next-release 2026-03-10 14:34:39 +00:00
Conversation 0 Commits 1 Files Changed 2 +220 -145
cal commented 2026-03-05 20:32:25 +00:00
Owner
Copy Link

Summary

Removes unused imports as identified in issue #30:

  • standings.py: removed import pydantic (line 4) — no pydantic models defined in this file
  • pitchingstats.py: removed import datetime (line 1) and import os (line 2) — neither module is used

Files Changed

  • app/routers_v3/standings.py
  • app/routers_v3/pitchingstats.py

Notes

The auto-formatter (ruff/black) reformatted both touched files on save (single→double quotes, line wrapping). This is consistent with previous PRs in this repo and is expected behavior per the project setup.

No logic changes were made beyond the import removals.

## Summary Removes unused imports as identified in issue #30: - `standings.py`: removed `import pydantic` (line 4) — no pydantic models defined in this file - `pitchingstats.py`: removed `import datetime` (line 1) and `import os` (line 2) — neither module is used ## Files Changed - `app/routers_v3/standings.py` - `app/routers_v3/pitchingstats.py` ## Notes The auto-formatter (ruff/black) reformatted both touched files on save (single→double quotes, line wrapping). This is consistent with previous PRs in this repo and is expected behavior per the project setup. No logic changes were made beyond the import removals.
cal added 1 commit 2026-03-05 20:32:26 +00:00
fix: remove unused imports in standings.py and pitchingstats.py (#30)
All checks were successful
Build Docker Image / build (pull_request) Successful in 2m7s
Details
9f4d3df2f3 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cal added the
ai-reviewing
 label 2026-03-05 20:45:04 +00:00
cal reviewed 2026-03-05 20:45:57 +00:00
cal left a comment
Author
Owner
Copy Link

AI Code Review

Files Reviewed

  • app/routers_v3/standings.py (modified)
  • app/routers_v3/pitchingstats.py (modified)

Findings

Correctness

  • standings.py: import pydantic correctly removed — confirmed no pydantic models are defined in this file. All other pydantic usage is absent.
  • pitchingstats.py: import datetime and import os correctly removed — confirmed neither is referenced anywhere in the file. import pydantic is correctly retained since PitStatModel and PitStatList inherit from pydantic.BaseModel.
  • No logic changes — the claimed scope (import removal only) is accurate.

Security

  • No issues introduced by this PR.
  • Pre-existing note (out of scope here): {token} is still interpolated in Bad Token log warnings in both files (e.g. patch_pitstats, post_pitstats, patch_standings, post_standings, recalculate_standings). This is tracked separately and should be addressed by PR #45.

Style & Conventions

  • Auto-formatter changes (single→double quotes, line wrapping) are consistent with the project's ruff/black setup and match the pattern established in previous PRs. Not a concern.

Suggestions

  • No suggestions.

Verdict: COMMENT

Clean dead-code removal. All three imports are confirmed unused, the retained import pydantic in pitchingstats.py is correct, and no logic was changed. Ready to merge.

Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `app/routers_v3/standings.py` (modified) - `app/routers_v3/pitchingstats.py` (modified) ### Findings #### Correctness - `standings.py`: `import pydantic` correctly removed — confirmed no pydantic models are defined in this file. All other pydantic usage is absent. - `pitchingstats.py`: `import datetime` and `import os` correctly removed — confirmed neither is referenced anywhere in the file. `import pydantic` is correctly retained since `PitStatModel` and `PitStatList` inherit from `pydantic.BaseModel`. - No logic changes — the claimed scope (import removal only) is accurate. #### Security - No issues introduced by this PR. - Pre-existing note (out of scope here): `{token}` is still interpolated in `Bad Token` log warnings in both files (e.g. `patch_pitstats`, `post_pitstats`, `patch_standings`, `post_standings`, `recalculate_standings`). This is tracked separately and should be addressed by PR #45. #### Style & Conventions - Auto-formatter changes (single→double quotes, line wrapping) are consistent with the project's ruff/black setup and match the pattern established in previous PRs. Not a concern. #### Suggestions - No suggestions. ### Verdict: COMMENT Clean dead-code removal. All three imports are confirmed unused, the retained `import pydantic` in `pitchingstats.py` is correct, and no logic was changed. Ready to merge. --- *Automated review by Claude PR Reviewer*
cal added
ai-reviewed
 and removed
ai-reviewing
 labels 2026-03-05 20:46:25 +00:00
cal changed target branch from main to next-release 2026-03-07 07:32:42 +00:00
cal merged commit 0f479c20a6 into next-release 2026-03-10 14:34:39 +00:00
cal deleted branch ai/major-domo-database-30 2026-03-10 14:34:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ai-changes-requested

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-reviewing

   
ai-working
No Label
ai-changes-requested
ai-pr-opened
ai-reviewed
ai-reviewing
ai-reviewing
ai-working
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/major-domo-database#49
No description provided.
Delete Branch "ai/major-domo-database-30"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?