cal/major-domo-database
1
0
Fork 0
Code Issues 25 Pull Requests 25 Actions Packages Projects Releases Wiki Activity

fix: Exclude deprecated pitcher_injury field from player responses #2

Merged
cal merged 3 commits from jarvis/testability into main 2026-02-04 20:05:19 +00:00
Conversation 0 Commits 3 Files Changed 3 +36 -18
cal commented 2026-02-04 19:56:03 +00:00
Owner
Copy Link

The pitcher_injury column is no longer used but was being included in all
player responses after the service layer refactor. This change restores the
previous behavior of filtering it out.

Changes:

  • Add EXCLUDED_FIELDS class constant to PlayerService
  • Filter excluded fields in _player_to_dict() method
  • Update _query_to_player_dicts() to use _player_to_dict() for all conversions
  • Applies to both JSON and CSV responses

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

The pitcher_injury column is no longer used but was being included in all player responses after the service layer refactor. This change restores the previous behavior of filtering it out. Changes: - Add EXCLUDED_FIELDS class constant to PlayerService - Filter excluded fields in _player_to_dict() method - Update _query_to_player_dicts() to use _player_to_dict() for all conversions - Applies to both JSON and CSV responses Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
cal added 1 commit 2026-02-04 19:56:04 +00:00
fix: Exclude deprecated pitcher_injury field from player responses
Some checks failed
Build Docker Image / build (pull_request) Has been cancelled
Details
d620dfc33d 
The pitcher_injury column is no longer used but was being included in all
player responses after the service layer refactor. This change restores the
previous behavior of filtering it out.

Changes:
- Add EXCLUDED_FIELDS class constant to PlayerService
- Filter excluded fields in _player_to_dict() method
- Update _query_to_player_dicts() to use _player_to_dict() for all conversions
- Applies to both JSON and CSV responses

Version bump: 2.4.1 -> 2.4.2

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
cal added 1 commit 2026-02-04 19:57:22 +00:00
Merge homelab/main and keep VERSION 2.5.1
All checks were successful
Build Docker Image / build (pull_request) Successful in 51s
Details
b5f01f6953
cal added 1 commit 2026-02-04 20:01:07 +00:00
feat: Add pagination support to /players endpoint
All checks were successful
Build Docker Image / build (pull_request) Successful in 2m19s
Details
332c445a12 
Add limit and offset parameters for paginated player queries.

Changes:
- Add limit parameter (minimum 1) to control page size
- Add offset parameter (minimum 0) to skip results
- Response now includes both 'count' (current page) and 'total' (all matches)
- Pagination applied after filtering and sorting

Example usage:
  /api/v3/players?season=12&limit=50&offset=0  (page 1)
  /api/v3/players?season=12&limit=50&offset=50 (page 2)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
cal merged commit 7e9669d9aa into main 2026-02-04 20:05:19 +00:00
cal deleted branch jarvis/testability 2026-02-04 20:05:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ai-changes-requested

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-reviewing

   
ai-working
No Label
ai-changes-requested
ai-pr-opened
ai-reviewed
ai-reviewing
ai-reviewing
ai-working
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/major-domo-database#2
No description provided.
Delete Branch "jarvis/testability"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?