chore: remove vestigial env vars from docker-compose (#121) #123

Claude · 2026-04-09T18:02:32Z

Claude commented

2026-04-09 18:02:32 +00:00

Closes #121

Changes

Removes WORKERS_PER_CORE, TIMEOUT, and GRACEFUL_TIMEOUT from docker-compose.yml. These were consumed by the old tiangolo/uvicorn-gunicorn-fastapi base image and are silently ignored since PR #115 switched to python:3.12-slim with an explicit uvicorn CMD.

Files changed

docker-compose.yml — removed 3 vestigial env vars

Remote changes (applied directly)

dev (ssh sba-db): removed the same 3 vars from ~/container-data/dev-sba-database/docker-compose.yml (no WEB_WORKERS added — Dockerfile default of 2 is appropriate for dev)
prod (ssh akamai): removed the same 3 vars from ~/container-data/sba-database/docker-compose.yml and added WEB_WORKERS=4 to override the Dockerfile default for production load

Closes #121 ## Changes Removes `WORKERS_PER_CORE`, `TIMEOUT`, and `GRACEFUL_TIMEOUT` from `docker-compose.yml`. These were consumed by the old `tiangolo/uvicorn-gunicorn-fastapi` base image and are silently ignored since PR #115 switched to `python:3.12-slim` with an explicit uvicorn CMD. ## Files changed - `docker-compose.yml` — removed 3 vestigial env vars ## Remote changes (applied directly) - **dev (`ssh sba-db`)**: removed the same 3 vars from `~/container-data/dev-sba-database/docker-compose.yml` (no `WEB_WORKERS` added — Dockerfile default of 2 is appropriate for dev) - **prod (`ssh akamai`)**: removed the same 3 vars from `~/container-data/sba-database/docker-compose.yml` and added `WEB_WORKERS=4` to override the Dockerfile default for production load

Claude added 1 commit 2026-04-09 18:02:34 +00:00

chore: remove vestigial env vars from docker-compose (#121 ) 22a3f8be8c

Closes #121

WORKERS_PER_CORE, TIMEOUT, and GRACEFUL_TIMEOUT were consumed by the
old tiangolo/uvicorn-gunicorn-fastapi base image and are silently
ignored since switching to python:3.12-slim with an explicit uvicorn CMD.

Also applied the same removal to dev (ssh sba-db) and prod (ssh akamai)
docker-compose files directly. Added WEB_WORKERS=4 to prod to override
the Dockerfile default of 2.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Claude referenced this pull request

2026-04-09 18:02:41 +00:00

chore: remove vestigial env vars from docker-compose #121

Claude reviewed 2026-04-09 18:16:46 +00:00

Claude left a comment

AI Code Review

Files Reviewed

docker-compose.yml (modified)

Findings

Correctness

No issues found. WORKERS_PER_CORE, TIMEOUT, and GRACEFUL_TIMEOUT are confirmed dead env vars — they were consumed by the tiangolo/uvicorn-gunicorn-fastapi startup script, which is gone since PR #115 switched to python:3.12-slim with an explicit CMD. The current CMD at Dockerfile:34 only reads $WEB_WORKERS, so these three vars have been silently ignored since that change.
ENV WEB_WORKERS=2 at Dockerfile:33 provides the correct default for dev without needing an override in docker-compose.yml. The production override (WEB_WORKERS=4) applied directly to the remote server is appropriately documented in the PR body.
The three remaining vars in the environment: block (DATABASE_TYPE, POSTGRES_HOST, etc.) are unaffected and still consumed by app code.

Security

No issues found.

Style & Conventions

No issues found. Pure deletion of dead config — no new code introduced.

Suggestions

DATABASE_TYPE=postgresql at docker-compose.yml:29 is a pre-existing vestige rendered inert by PR #89's removal of the SQLite fallback. Not in scope here, but worth a follow-up cleanup ticket alongside any future docker-compose housekeeping.

Verdict: COMMENT

Clean removal of three dead env vars left over from the base image migration. Dockerfile default (WEB_WORKERS=2) makes the dev compose correct with no additions; prod override is handled out-of-band as documented. Approved.

Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `docker-compose.yml` (modified) ### Findings #### Correctness - No issues found. `WORKERS_PER_CORE`, `TIMEOUT`, and `GRACEFUL_TIMEOUT` are confirmed dead env vars — they were consumed by the `tiangolo/uvicorn-gunicorn-fastapi` startup script, which is gone since PR #115 switched to `python:3.12-slim` with an explicit `CMD`. The current `CMD` at `Dockerfile:34` only reads `$WEB_WORKERS`, so these three vars have been silently ignored since that change. - `ENV WEB_WORKERS=2` at `Dockerfile:33` provides the correct default for dev without needing an override in docker-compose.yml. The production override (`WEB_WORKERS=4`) applied directly to the remote server is appropriately documented in the PR body. - The three remaining vars in the `environment:` block (`DATABASE_TYPE`, `POSTGRES_HOST`, etc.) are unaffected and still consumed by app code. #### Security - No issues found. #### Style & Conventions - No issues found. Pure deletion of dead config — no new code introduced. #### Suggestions - `DATABASE_TYPE=postgresql` at `docker-compose.yml:29` is a pre-existing vestige rendered inert by PR #89's removal of the SQLite fallback. Not in scope here, but worth a follow-up cleanup ticket alongside any future docker-compose housekeeping. ### Verdict: COMMENT Clean removal of three dead env vars left over from the base image migration. Dockerfile default (`WEB_WORKERS=2`) makes the dev compose correct with no additions; prod override is handled out-of-band as documented. Approved. --- *Automated review by Claude PR Reviewer*

Claude added the

ai-reviewed

label 2026-04-09 18:17:00 +00:00

cal force-pushed issue/121-chore-remove-vestigial-env-vars-from-docker-compos from 22a3f8be8c to 99fbb3848b

2026-04-10 15:53:25 +00:00

Compare

cal merged commit 1b10933ca1 into main

2026-04-10 15:53:34 +00:00

cal deleted branch issue/121-chore-remove-vestigial-env-vars-from-docker-compos

2026-04-10 15:53:34 +00:00

cal referenced this issue from a commit

2026-04-10 15:53:35 +00:00