cal/major-domo-database
1
0
Fork 0
Code Issues 25 Pull Requests 25 Actions Packages Projects Releases Wiki Activity

fix: raise HTTPException in recalculate_standings on failure (#23) #41

Merged
cal merged 1 commits from ai/major-domo-database-23 into main 2026-03-03 03:47:30 +00:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
cal commented 2026-03-03 01:36:38 +00:00
Owner
Copy Link

Summary

  • Adds the missing raise keyword before HTTPException(status_code=500, ...) in recalculate_standings (line 124)
  • Without raise, the exception was constructed but immediately discarded, causing the endpoint to always return 200 regardless of whether recalculation succeeded

Change

File: app/routers_v3/standings.py

-        HTTPException(status_code=500, detail=f'Error recreating Standings rows')
+        raise HTTPException(status_code=500, detail=f'Error recreating Standings rows')

This is a one-word change. No reformatting, no quote changes, no other modifications.

Test plan

  • Verify the endpoint returns HTTP 500 when Standings.recalculate(season) returns code 69
  • Verify the endpoint still returns 200 on successful recalculation

Note: The previous PR (#40) for this issue was rejected because the linter reformatted the entire file. This PR contains only the single word fix.

Generated with Claude Code

## Summary - Adds the missing `raise` keyword before `HTTPException(status_code=500, ...)` in `recalculate_standings` (line 124) - Without `raise`, the exception was constructed but immediately discarded, causing the endpoint to always return 200 regardless of whether recalculation succeeded ## Change **File:** `app/routers_v3/standings.py` ```diff - HTTPException(status_code=500, detail=f'Error recreating Standings rows') + raise HTTPException(status_code=500, detail=f'Error recreating Standings rows') ``` This is a one-word change. No reformatting, no quote changes, no other modifications. ## Test plan - [ ] Verify the endpoint returns HTTP 500 when `Standings.recalculate(season)` returns code 69 - [ ] Verify the endpoint still returns 200 on successful recalculation Note: The previous PR (#40) for this issue was rejected because the linter reformatted the entire file. This PR contains only the single word fix. Generated with [Claude Code](https://claude.com/claude-code)
cal added 1 commit 2026-03-03 01:36:39 +00:00
fix: raise HTTPException in recalculate_standings on failure (#23)
All checks were successful
Build Docker Image / build (pull_request) Successful in 1m57s
Details
6d479bc2b0 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cal force-pushed ai/major-domo-database-23 from 6d479bc2b0 to 4b288c1e67 2026-03-03 03:44:55 +00:00 Compare
cal merged commit ddf5f77da4 into main 2026-03-03 03:47:30 +00:00
cal deleted branch ai/major-domo-database-23 2026-03-03 03:47:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ai-changes-requested

   
ai-pr-opened

   
ai-reviewed

   
ai-reviewing

   
ai-reviewing

   
ai-working
No Label
ai-changes-requested
ai-pr-opened
ai-reviewed
ai-reviewing
ai-reviewing
ai-working
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cal/major-domo-database#41
No description provided.
Delete Branch "ai/major-domo-database-23"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?