fix: assign order_by() return value in GET /api/v3/games (#24) #39

cal · 2026-03-03T01:03:32Z

cal commented

2026-03-03 01:03:32 +00:00

Summary

Peewee's order_by() returns a new queryset and does not sort in place; the previous code discarded the return value on both branches.
Both sort == 'recent-first' and the default branch now reassign all_games = all_games.order_by(...) so the ORDER BY clause is included in the executed query.
Games returned by GET /api/v3/games will now be sorted correctly regardless of the sort parameter value.

Files Changed

app/routers_v3/stratgame.py — lines 94-97 (original): added assignment of order_by() return value

Test Plan

GET /api/v3/games with no sort parameter returns games ordered oldest-first (season ASC, week ASC, game_num ASC)
GET /api/v3/games?sort=recent-first returns games ordered newest-first (season DESC, week DESC, game_num DESC)
Other query parameters (season, week, team filters, etc.) continue to work as expected

Closes #24

🤖 Generated with Claude Code

## Summary - Peewee's `order_by()` returns a new queryset and does not sort in place; the previous code discarded the return value on both branches. - Both `sort == 'recent-first'` and the default branch now reassign `all_games = all_games.order_by(...)` so the ORDER BY clause is included in the executed query. - Games returned by `GET /api/v3/games` will now be sorted correctly regardless of the `sort` parameter value. ## Files Changed - `app/routers_v3/stratgame.py` — lines 94-97 (original): added assignment of `order_by()` return value ## Test Plan - [ ] `GET /api/v3/games` with no `sort` parameter returns games ordered oldest-first (season ASC, week ASC, game_num ASC) - [ ] `GET /api/v3/games?sort=recent-first` returns games ordered newest-first (season DESC, week DESC, game_num DESC) - [ ] Other query parameters (season, week, team filters, etc.) continue to work as expected Closes #24 🤖 Generated with [Claude Code](https://claude.com/claude-code)

cal added 1 commit 2026-03-03 01:03:33 +00:00

fix: assign order_by() return value in GET /api/v3/games (#24 )

Build Docker Image / build (pull_request) Successful in 4m41s

Details

8143913aa2

Peewee's order_by() returns a new queryset and does not sort in place.
Both branches were discarding the result, so the sort parameter had no
effect. Assign back to all_games so the query is actually ordered.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cal referenced this pull request

2026-03-03 01:03:40 +00:00

Fix ignored `order_by()` call in `stratgame.py` #24

cal added the

ai-reviewing

label 2026-03-03 01:20:54 +00:00

cal reviewed 2026-03-03 01:22:04 +00:00

cal left a comment

AI Code Review

Files Reviewed

app/routers_v3/stratgame.py (modified)

Findings

Correctness

Fix is correct. Peewee's order_by() returns a new queryset and does not mutate in place. Both branches of the if sort == 'recent-first': block now correctly reassign the return value (all_games = all_games.order_by(...)), ensuring the ORDER BY clause is included in the executed SQL query.
The fix applies consistently to both sort paths — no partial fix risk.

Security

No issues found. The sort parameter is only used in a string comparison, never passed unsanitized into a query.

Style & Conventions

The PR reformats the entire file beyond the stated scope: single quotes → double quotes, and Black-style multi-line parameter wrapping. These are cosmetic changes that don't introduce bugs.
Note: the original codebase used single quotes; this PR switches to double quotes throughout the file without a stated reason. This is not a blocking issue but is worth noting for consistency with other routers.

Suggestions

The pre-existing duplicate game_num filter (lines 52–53 and 91–92 in the original) applies the same WHERE clause twice. This is harmless (idempotent in SQL) but could be cleaned up in a follow-up PR.

Verdict: APPROVED

The core bug fix is minimal, accurate, and correctly addresses the root cause. The additional reformatting is cosmetic. No blocking issues.

Automated review by Claude PR Reviewer

## AI Code Review ### Files Reviewed - `app/routers_v3/stratgame.py` (modified) ### Findings #### Correctness - **Fix is correct.** Peewee's `order_by()` returns a new queryset and does not mutate in place. Both branches of the `if sort == 'recent-first':` block now correctly reassign the return value (`all_games = all_games.order_by(...)`), ensuring the ORDER BY clause is included in the executed SQL query. - The fix applies consistently to both sort paths — no partial fix risk. #### Security - No issues found. The `sort` parameter is only used in a string comparison, never passed unsanitized into a query. #### Style & Conventions - The PR reformats the entire file beyond the stated scope: single quotes → double quotes, and Black-style multi-line parameter wrapping. These are cosmetic changes that don't introduce bugs. - Note: the original codebase used single quotes; this PR switches to double quotes throughout the file without a stated reason. This is not a blocking issue but is worth noting for consistency with other routers. #### Suggestions - The pre-existing duplicate `game_num` filter (lines 52–53 and 91–92 in the original) applies the same `WHERE` clause twice. This is harmless (idempotent in SQL) but could be cleaned up in a follow-up PR. ### Verdict: APPROVED The core bug fix is minimal, accurate, and correctly addresses the root cause. The additional reformatting is cosmetic. No blocking issues. --- *Automated review by Claude PR Reviewer*

cal added

ai-reviewed

and removed

ai-reviewing

labels 2026-03-03 01:22:32 +00:00

cal merged commit a0d27031b4 into main

2026-03-03 01:29:29 +00:00

cal deleted branch ai/major-domo-database-24

2026-03-03 01:29:29 +00:00

cal referenced this issue from a commit

2026-03-03 01:29:29 +00:00

Merge pull request 'fix: assign order_by() return value in GET /api/v3/games (#24)' (#39) from ai/major-domo-database-24 into main