Cal Corum 7d8aad5554 feat: initial commit — 20 plugins (10 agents, 10 skills)

Agents: architect, claude-researcher, designer, engineer, issue-worker,
pentester, pr-reviewer, swarm-coder, swarm-reviewer, swarm-validator

Skills: backlog, create-scheduled-task, json-pretty, optimise-claude,
playwright-cli, project-plan, resume-tailoring, save-doc,
youtube-transcriber, z-image

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

2026-03-18 23:04:27 -05:00

1.3 KiB

Raw Blame History

title

description

type

domain

Fix: Scout Token Purchase Not Deducting Currency

Date: 2026-03-15 PR: #90 Severity: High — players getting free tokens

Problem

The /buy scout-token command completed successfully but didn't deduct the 200₼ cost. Players could buy unlimited tokens.

Root Cause

The buy handler used db_patch('/players/{id}', {'scout_tokens': new_count}) to increment tokens, but this endpoint doesn't trigger the money deduction side-effect. The dedicated /players/{id}/money endpoint handles balance validation and atomic deduction.

Fix

Replaced the db_patch call with a two-step flow:

POST /players/{id}/money with {"amount": -200, "reason": "scout_token_purchase"}
Only increment scout_tokens if the money call succeeds

Lessons

Always use dedicated money endpoints for currency operations — never raw patches
The db_patch helper bypasses business logic by design (it's for admin corrections)
Added integration test covering the full buy→deduct→verify flow

1.3 KiB Raw Blame History

Fix: Scout Token Purchase Not Deducting Currency

Problem

Root Cause

Fix

Lessons

1.3 KiB

Raw Blame History