1.0 KiB
1.0 KiB
| id | type | title | tags | importance | confidence | created | updated | |||
|---|---|---|---|---|---|---|---|---|---|---|
| 91e3a804-1d80-4a19-a968-fd47f5ed5aad | workflow | PR review: paper-dynasty-database#48 (APPROVED) |
|
0.5 | 0.8 | 2026-03-05T04:18:52.073987+00:00 | 2026-03-05T04:18:52.073987+00:00 |
Reviewed paper-dynasty-database PR #48 — fix: replace broad except Exception blocks with DoesNotExist (#15). Verdict: APPROVED. Summary: Clean, focused fix applied consistently across 19 files. Narrowing from except Exception to except DoesNotExist is technically correct — peewee.DoesNotExist is exactly what Model.get_by_id() raises on miss, and it is the base class for all model-specific DoesNotExist exceptions. Import path via db_engine (which does from peewee import *) is valid. Real DB errors now propagate as 500s instead of being masked as 404s. No security or style issues. Note: Gitea blocked a formal APPROVED review state (self-review restriction); posted as COMMENT with APPROVED verdict.. Cost: $0.40518499999999996