1.9 KiB
1.9 KiB
| id | type | title | tags | importance | confidence | created | updated | relations | |||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| c29e169a-896c-4b80-9b69-22c2880d61d7 | workflow | PR review: paper-dynasty-database#32 — remove debug print(req.scope) |
|
0.4 | 0.8 | 2026-03-03T05:03:15.987587+00:00 | 2026-03-03T15:05:45.278648+00:00 |
|
PR Review: paper-dynasty-database#32
Verdict: APPROVED (posted as COMMENT due to Gitea self-approval restriction)
PR: Remove debug print(req.scope) from get_docs route in app/main.py
Author: cal
Closes: #31
Files Reviewed
app/main.py
Key Findings
- Functional change: removal of
print(req.scope)debug statement that fired on every/api/docsload - Linter reformatting included (single→double quotes, trailing commas, expanded imports) — cosmetic only
- Minor security improvement: ASGI scope can contain Authorization headers; removing the print prevents accidental token logging to stdout/Docker logs
- No logic changes, no new imports, no test impact
Notes
- Gitea does not allow self-approval; review posted as COMMENT state with APPROVED verdict in body
- Pre-existing issue noted (not flagged):
f"0.1.1"f-string with no interpolation inopenapi()