100 lines
3.5 KiB
Markdown
100 lines
3.5 KiB
Markdown
---
|
|
id: 04e57a23-0a20-49d6-8c5a-2fa5fc4e55b5
|
|
type: workflow
|
|
title: "PR review: paper-dynasty-database#33 (APPROVED)"
|
|
tags: [pr-reviewer, paper-dynasty-database, fastapi, peewee, middleware, python]
|
|
importance: 0.5
|
|
confidence: 0.8
|
|
created: "2026-03-03T18:08:58.224854+00:00"
|
|
updated: "2026-03-04T03:50:21.014819+00:00"
|
|
relations:
|
|
- target: d36a86f0-8183-4c94-8d63-0be65d3fd63a
|
|
type: RELATED_TO
|
|
direction: outgoing
|
|
strength: 0.84
|
|
edge_id: 24d0a02d-0960-4c13-b14f-856c53a5b913
|
|
- target: 1e6628fa-dc5d-4047-a9ae-ecb884e04ba2
|
|
type: RELATED_TO
|
|
direction: outgoing
|
|
strength: 0.75
|
|
edge_id: 2081ecc0-91a1-4e57-a26d-b96e631e7b16
|
|
- target: 25a63239-d077-4a92-8466-0900e16b837f
|
|
type: RELATED_TO
|
|
direction: outgoing
|
|
strength: 0.74
|
|
edge_id: 92a1af4d-2dc8-4672-bce1-33f09bde6a19
|
|
- target: 530bfb6f-841c-4381-b8a4-d0b6fbc02878
|
|
type: RELATED_TO
|
|
direction: incoming
|
|
strength: 0.7
|
|
edge_id: b210b16d-b168-4798-b73f-98ef27f46dd8
|
|
- target: 29f1641c-5539-4814-8efa-c03692025c15
|
|
type: RELATED_TO
|
|
direction: incoming
|
|
strength: 0.8
|
|
edge_id: 82c2dfef-28b1-4e09-a5b4-94a83a4dcbd5
|
|
- target: 650babda-b99b-4017-92b7-692bada7669d
|
|
type: RELATED_TO
|
|
direction: incoming
|
|
strength: 0.72
|
|
edge_id: d2bdb6b1-395e-4740-a402-b588331b72ba
|
|
- target: cd43d051-d2e8-436e-b964-f9260739cc15
|
|
type: RELATED_TO
|
|
direction: incoming
|
|
strength: 0.75
|
|
edge_id: 13f7c174-b2d6-4f57-846c-a2a66a2784f0
|
|
- target: bf1e80d7-cec9-4853-85a4-260f2fe3e0eb
|
|
type: RELATED_TO
|
|
direction: incoming
|
|
strength: 0.79
|
|
edge_id: 3561b670-7afa-4a12-8131-5b099f890db5
|
|
- target: 07eb63c2-1823-4f26-b976-a725ea5ab324
|
|
type: RELATED_TO
|
|
direction: incoming
|
|
strength: 0.74
|
|
edge_id: 4b69329c-2881-4d73-b690-3567df580e5f
|
|
- target: e5d04c92-8f16-44b4-a6f3-94317ea88758
|
|
type: RELATED_TO
|
|
direction: incoming
|
|
strength: 0.73
|
|
edge_id: 987e2566-a9ab-4dcb-b162-3c2285ef2686
|
|
- target: 8028aeb5-d922-49aa-b0e6-fbc1cce35484
|
|
type: RELATED_TO
|
|
direction: incoming
|
|
strength: 0.72
|
|
edge_id: 776cac00-9382-4283-a294-392d70259109
|
|
- target: 38e7784c-1250-4123-9a20-1a75ad1e37d8
|
|
type: RELATED_TO
|
|
direction: incoming
|
|
strength: 0.81
|
|
edge_id: ccf281c7-6a64-427e-85f6-45ba260fe9f5
|
|
- target: 802b350e-296c-448a-9f76-8684e786b3b3
|
|
type: RELATED_TO
|
|
direction: incoming
|
|
strength: 0.79
|
|
edge_id: d1610aeb-7f7f-4d7d-9911-b32a5e2fbd7c
|
|
- target: c9b2c04d-258a-4028-849b-a47f6168a6ab
|
|
type: RELATED_TO
|
|
direction: incoming
|
|
strength: 0.79
|
|
edge_id: 74dd0ac6-e39b-4fad-a669-8603c077c366
|
|
- target: c98ad146-a578-430b-af4e-2ecda68361f1
|
|
type: RELATED_TO
|
|
direction: incoming
|
|
strength: 0.84
|
|
edge_id: 6d1cd6b5-007e-4d49-bee2-83dacfd1f96f
|
|
---
|
|
|
|
Reviewed paper-dynasty-database PR #33 — fix: replace 467 manual db.close() calls with middleware (#30). Verdict: APPROVED.
|
|
|
|
**Summary:** Correct implementation of the standard Peewee + FastAPI middleware pattern. Eliminates connection-leak bug across 467 call sites. Safe for both SQLite (dev) and PooledPostgresqlDatabase (prod).
|
|
|
|
**Key findings:**
|
|
- Middleware uses `reuse_if_open=True` and `is_closed()` guard — correct
|
|
- Diff: exactly 467 db.close() removals, 0 other router logic changes
|
|
- 15 router files will have unused `db` imports post-merge (flagged for follow-up)
|
|
- Middleware placement after include_router() is valid in Starlette
|
|
- Gitea blocks self-approval; posted as COMMENT with APPROVED recommendation
|
|
|
|
**Files changed:** app/main.py + 30 routers_v2 files
|