claude-memory/graph/workflows/pr-review-paper-dynasty-database35-remove-dead-roster-csv-fi-b1eb16.md

id	type	title	tags	importance	confidence	created	updated	relations
b1eb1655-e006-447d-a0cf-bba7a914b331	workflow	PR review: paper-dynasty-database#35 — remove dead roster CSV fields	pr-reviewer paper-dynasty paper-dynasty-database fastapi python csv dead-code card-model	0.4	0.8	2026-03-03T18:35:29.790614+00:00	2026-03-03T19:33:19.943378+00:00	target type direction strength edge_id 25a63239-d077-4a92-8466-0900e16b837f RELATED_TO outgoing 0.75 45f4e1cd-28e6-414b-87e3-fd40f23aba05 target type direction strength edge_id 1e6628fa-dc5d-4047-a9ae-ecb884e04ba2 RELATED_TO outgoing 0.75 ddc78d81-e14e-4e47-9af4-3e1312a26bb3 target type direction strength edge_id d36a86f0-8183-4c94-8d63-0be65d3fd63a RELATED_TO outgoing 0.7 58e767ee-ef21-42a5-afd8-1d96917849bb target type direction strength edge_id 62d0f73d-8854-4c71-9001-60b38d438534 RELATED_TO incoming 0.78 b4aad7b7-3664-4ed7-887c-389cacc7d265 target type direction strength edge_id a08cfd86-d519-41cd-b93e-0877e11c7cc3 RELATED_TO incoming 0.85 84892a1f-730c-4967-8294-db09c17ad676

PR Review: paper-dynasty-database#35

Verdict: APPROVED (posted as COMMENT — Gitea blocks self-approval)

Fix: Removed non-existent roster1.name, roster2.name, roster3.name attribute accesses from v1_cards_get_one CSV branch in app/routers_v2/cards.py (lines 144–146).

Confirmed: Card model in db_engine.py (lines 472–491) has only player, team, pack, value fields. The removed attributes would have raised AttributeError on every ?csv=true request.

Pre-existing issue noted (out of scope): v1_cards_patch still accepts roster1_id, roster2_id, roster3_id params and assigns them to this_card (lines 332–337), but Peewee silently drops unknown attributes on save — no runtime error, just dead API surface.

Note: Gitea does not allow APPROVED reviews on your own PRs. Posted as COMMENT instead.