cal/claude-memory
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity
8bebcecdbd
claude-memory/graph/workflows/pr-review-paper-dynasty-database33-approved-04e57a.md

2.5 KiB
Raw Blame History

id type title tags importance confidence created updated relations
04e57a23-0a20-49d6-8c5a-2fa5fc4e55b5 workflow PR review: paper-dynasty-database#33 (APPROVED)
pr-reviewer
paper-dynasty-database
fastapi
peewee
middleware
python
0.5 0.8 2026-03-03T18:08:58.224854+00:00 2026-03-03T22:48:00.696003+00:00
target type direction strength edge_id
d36a86f0-8183-4c94-8d63-0be65d3fd63a RELATED_TO outgoing 0.84 24d0a02d-0960-4c13-b14f-856c53a5b913
target type direction strength edge_id
1e6628fa-dc5d-4047-a9ae-ecb884e04ba2 RELATED_TO outgoing 0.75 2081ecc0-91a1-4e57-a26d-b96e631e7b16
target type direction strength edge_id
25a63239-d077-4a92-8466-0900e16b837f RELATED_TO outgoing 0.74 92a1af4d-2dc8-4672-bce1-33f09bde6a19
target type direction strength edge_id
530bfb6f-841c-4381-b8a4-d0b6fbc02878 RELATED_TO incoming 0.7 b210b16d-b168-4798-b73f-98ef27f46dd8
target type direction strength edge_id
29f1641c-5539-4814-8efa-c03692025c15 RELATED_TO incoming 0.8 82c2dfef-28b1-4e09-a5b4-94a83a4dcbd5
target type direction strength edge_id
650babda-b99b-4017-92b7-692bada7669d RELATED_TO incoming 0.72 d2bdb6b1-395e-4740-a402-b588331b72ba
target type direction strength edge_id
cd43d051-d2e8-436e-b964-f9260739cc15 RELATED_TO incoming 0.75 13f7c174-b2d6-4f57-846c-a2a66a2784f0
target type direction strength edge_id
bf1e80d7-cec9-4853-85a4-260f2fe3e0eb RELATED_TO incoming 0.79 3561b670-7afa-4a12-8131-5b099f890db5
target type direction strength edge_id
07eb63c2-1823-4f26-b976-a725ea5ab324 RELATED_TO incoming 0.74 4b69329c-2881-4d73-b690-3567df580e5f

Reviewed paper-dynasty-database PR #33 — fix: replace 467 manual db.close() calls with middleware (#30). Verdict: APPROVED.

Summary: Correct implementation of the standard Peewee + FastAPI middleware pattern. Eliminates connection-leak bug across 467 call sites. Safe for both SQLite (dev) and PooledPostgresqlDatabase (prod).

Key findings:

  • Middleware uses reuse_if_open=True and is_closed() guard — correct
  • Diff: exactly 467 db.close() removals, 0 other router logic changes
  • 15 router files will have unused db imports post-merge (flagged for follow-up)
  • Middleware placement after include_router() is valid in Starlette
  • Gitea blocks self-approval; posted as COMMENT with APPROVED recommendation

Files changed: app/main.py + 30 routers_v2 files