cal/claude-memory
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity
82b06f7f37
claude-memory/graph/workflows/pr-review-paper-dynasty-database33-approved-04e57a.md

1.6 KiB
Raw Blame History

id type title tags importance confidence created updated relations
04e57a23-0a20-49d6-8c5a-2fa5fc4e55b5 workflow PR review: paper-dynasty-database#33 (APPROVED)
pr-reviewer
paper-dynasty-database
fastapi
peewee
middleware
python
0.5 0.8 2026-03-03T18:08:58.224854+00:00 2026-03-03T18:08:58.604732+00:00
target type direction strength edge_id
d36a86f0-8183-4c94-8d63-0be65d3fd63a RELATED_TO outgoing 0.84 24d0a02d-0960-4c13-b14f-856c53a5b913
target type direction strength edge_id
1e6628fa-dc5d-4047-a9ae-ecb884e04ba2 RELATED_TO outgoing 0.75 2081ecc0-91a1-4e57-a26d-b96e631e7b16
target type direction strength edge_id
25a63239-d077-4a92-8466-0900e16b837f RELATED_TO outgoing 0.74 92a1af4d-2dc8-4672-bce1-33f09bde6a19

Reviewed paper-dynasty-database PR #33 — fix: replace 467 manual db.close() calls with middleware (#30). Verdict: APPROVED.

Summary: Correct implementation of the standard Peewee + FastAPI middleware pattern. Eliminates connection-leak bug across 467 call sites. Safe for both SQLite (dev) and PooledPostgresqlDatabase (prod).

Key findings:

  • Middleware uses reuse_if_open=True and is_closed() guard — correct
  • Diff: exactly 467 db.close() removals, 0 other router logic changes
  • 15 router files will have unused db imports post-merge (flagged for follow-up)
  • Middleware placement after include_router() is valid in Starlette
  • Gitea blocks self-approval; posted as COMMENT with APPROVED recommendation

Files changed: app/main.py + 30 routers_v2 files