53 lines
1.9 KiB
Markdown
53 lines
1.9 KiB
Markdown
---
|
|
id: c29e169a-896c-4b80-9b69-22c2880d61d7
|
|
type: workflow
|
|
title: "PR review: paper-dynasty-database#32 — remove debug print(req.scope)"
|
|
tags: [pr-reviewer, paper-dynasty-database, fastapi, python, debug-cleanup]
|
|
importance: 0.4
|
|
confidence: 0.8
|
|
created: "2026-03-03T05:03:15.987587+00:00"
|
|
updated: "2026-03-03T15:05:45.278648+00:00"
|
|
relations:
|
|
- target: 947fe7fd-b23c-4e46-8065-51c0519f2756
|
|
type: RELATED_TO
|
|
direction: outgoing
|
|
strength: 0.84
|
|
edge_id: d23b14a5-0995-4353-903e-3631bc9d0888
|
|
- target: 25a63239-d077-4a92-8466-0900e16b837f
|
|
type: RELATED_TO
|
|
direction: outgoing
|
|
strength: 0.88
|
|
edge_id: fe74aa9c-f730-4e6a-80bd-cc8bcf097159
|
|
- target: 3e5fe8fc-59df-4874-b680-7c26d602a758
|
|
type: RELATED_TO
|
|
direction: outgoing
|
|
strength: 0.67
|
|
edge_id: 2fa8f950-eb1d-46e9-9fee-9b01ce6e66d7
|
|
- target: c9d70b95-e7af-44e9-bfe9-e57d59f21b48
|
|
type: RELATED_TO
|
|
direction: incoming
|
|
strength: 0.79
|
|
edge_id: 3ddcbc0e-54d9-44e4-9ba9-e09b3931fe96
|
|
---
|
|
|
|
## PR Review: paper-dynasty-database#32
|
|
|
|
**Verdict**: APPROVED (posted as COMMENT due to Gitea self-approval restriction)
|
|
|
|
**PR**: Remove debug `print(req.scope)` from `get_docs` route in `app/main.py`
|
|
**Author**: cal
|
|
**Closes**: #31
|
|
|
|
### Files Reviewed
|
|
- `app/main.py`
|
|
|
|
### Key Findings
|
|
- Functional change: removal of `print(req.scope)` debug statement that fired on every `/api/docs` load
|
|
- Linter reformatting included (single→double quotes, trailing commas, expanded imports) — cosmetic only
|
|
- Minor security improvement: ASGI scope can contain Authorization headers; removing the print prevents accidental token logging to stdout/Docker logs
|
|
- No logic changes, no new imports, no test impact
|
|
|
|
### Notes
|
|
- Gitea does not allow self-approval; review posted as COMMENT state with APPROVED verdict in body
|
|
- Pre-existing issue noted (not flagged): `f"0.1.1"` f-string with no interpolation in `openapi()`
|